Re: [PATCH 5.1] zread: read files in 4k chunks

Path	csiph.com!goblin1!goblin.stu.neva.ru!usenet.stanford.edu!not-for-mail
From	"Jason A. Donenfeld" <Jason@zx2c4.com>
Newsgroups	gnu.bash.bug
Subject	Re: [PATCH 5.1] zread: read files in 4k chunks
Date	Mon, 22 Jun 2020 12:50:03 -0600
Lines	12
Approved	bug-bash@gnu.org
Message-ID	<mailman.276.1592851819.2574.bug-bash@gnu.org> (permalink)
References	<20200622055328.155106-1-Jason@zx2c4.com> <3cac1f66-697d-396d-3dc8-fc5b621638a4@case.edu> <CAHmME9rHTCpeOaNwA1huBnBrL76qe-SHj=-cQYj_nEaMveGP=w@mail.gmail.com>
NNTP-Posting-Host	lists.gnu.org
Mime-Version	1.0
Content-Type	text/plain; charset="UTF-8"
X-Trace	usenet.stanford.edu 1592851819 18525 209.51.188.17 (22 Jun 2020 18:50:19 GMT)
X-Complaints-To	action@cs.stanford.edu
Cc	bug-bash@gnu.org
To	Chester Ramey <chet.ramey@case.edu>
Envelope-to	bug-bash@gnu.org
DKIM-Signature	v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=mime-version :references:in-reply-to:from:date:message-id:subject:to:cc :content-type; s=mail; bh=mf2MC0hI0tpUhGxdJ+n7GeLXRnI=; b=dRGFrk TJUH90oU1+FL/SJMT7h8r6SWg2CakT0C1aSipDxJksQPv/0sCopvTKtBFpS/8E7i Vy+pTLCKKFT2CIgn/AX9YFxJomRvvOyi/aAKFuViv58J6PzofkOw8TlJ3AI0WLCg 8KnVwyXUZRPmYcrZIyyaBZkYTR2wE/ONbnuVOtNyD3eJimvCTGg+QMrtoRn2nfF7 UwD2eqntSadhe2qD7Mn27bqp4fnAOWDHzBeFlRhVzsiWeqRHmibahj0IdM2fY/MV MRAs1z196LpnGz2zBDX4FVu9mIHnWr6R+VnRzuchkNOW7IlD3SLA3GSeUipCGF90 FK0fOdAGR9uHd/eA==
X-Gm-Message-State	AOAM531jv6nnTHyeBExLs7efjbccTNjjSR+gQGrDUXsb0MuZZQxkmGI2 Gi2DVOd2vaJSTOPYdbo4lB5iH/cyfL2MxQIrw+8=
X-Google-Smtp-Source	ABdhPJyT3X5PyFUnrcTBOM6I946N+npke8/J8knIBZujqNF9wAkZWAQ5W4G6ItGsJqeE2h4KD0SxD4yYRJk4WPj7K/E=
X-Received	by 2002:a05:6638:1405:: with SMTP id k5mr18710878jad.108.1592851814127; Mon, 22 Jun 2020 11:50:14 -0700 (PDT)
In-Reply-To	<3cac1f66-697d-396d-3dc8-fc5b621638a4@case.edu>
X-Gmail-Original-Message-ID	<CAHmME9rHTCpeOaNwA1huBnBrL76qe-SHj=-cQYj_nEaMveGP=w@mail.gmail.com>
Received-SPF	pass client-ip=192.95.5.64; envelope-from=Jason@zx2c4.com; helo=mail.zx2c4.com
X-detected-operating-system	by eggs.gnu.org: First seen = 2020/06/22 14:50:15
X-ACL-Warn	Detected OS = Linux 3.11 and newer
X-Spam_score_int	-20
X-Spam_score	-2.1
X-Spam_bar	--
X-Spam_report	(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN
X-Spam_action	no action
X-BeenThere	bug-bash@gnu.org
X-Mailman-Version	2.1.23
Precedence	list
List-Id	Bug reports for the GNU Bourne Again SHell <bug-bash.gnu.org>
List-Unsubscribe	<https://lists.gnu.org/mailman/options/bug-bash>, <mailto:bug-bash-request@gnu.org?subject=unsubscribe>
List-Archive	<https://lists.gnu.org/archive/html/bug-bash>
List-Post	<mailto:bug-bash@gnu.org>
List-Help	<mailto:bug-bash-request@gnu.org?subject=help>
List-Subscribe	<https://lists.gnu.org/mailman/listinfo/bug-bash>, <mailto:bug-bash-request@gnu.org?subject=subscribe>
X-Mailman-Original-Message-ID	<CAHmME9rHTCpeOaNwA1huBnBrL76qe-SHj=-cQYj_nEaMveGP=w@mail.gmail.com>
X-Mailman-Original-References	<20200622055328.155106-1-Jason@zx2c4.com> <3cac1f66-697d-396d-3dc8-fc5b621638a4@case.edu>
Xref	csiph.com gnu.bash.bug:16431

Show key headers only | View raw

Hi Chet,

A little bit larger than 1024, I believe, so 2048 would be reasonable.

However, consider taking this patch as-is with the 4096 page size.
This will yield much better performance and have basically no
drawbacks on any system.

Another place lbuf should be increased is in zcatfd, by the way.

Jason

Back to gnu.bash.bug | Previous | Next | Find similar

Thread

Re: [PATCH 5.1] zread: read files in 4k chunks "Jason A. Donenfeld" <Jason@zx2c4.com> - 2020-06-22 12:50 -0600

csiph-web