Re: [PATCH] Fix a problem `rl_bind_key' cannot create shadow binding for `C-@'

Path	csiph.com!xmission!news.snarked.org!news.linkpendium.com!news.linkpendium.com!panix!usenet.stanford.edu!not-for-mail
From	Chet Ramey <chet.ramey@case.edu>
Newsgroups	gnu.bash.bug
Subject	Re: [PATCH] Fix a problem `rl_bind_key' cannot create shadow binding for `C-@'
Date	Wed, 15 Jan 2020 10:23:44 -0500
Lines	22
Approved	bug-bash@gnu.org
Message-ID	<mailman.2613.1579101835.1979.bug-bash@gnu.org> (permalink)
References	<CAFLRLk9R5wexNV53fx6-V3rQEwKExfJsoDanZ9JqGFatG9GnKg@mail.gmail.com> <59dee32e-2988-fe21-f5f6-5d722cf1e82a@case.edu>
Reply-To	chet.ramey@case.edu
NNTP-Posting-Host	lists.gnu.org
Mime-Version	1.0
Content-Type	text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding	7bit
X-Trace	usenet.stanford.edu 1579101835 10484 209.51.188.17 (15 Jan 2020 15:23:55 GMT)
X-Complaints-To	action@cs.stanford.edu
Cc	chet.ramey@case.edu
To	Koichi Murase <myoga.murase@gmail.com>, bug-bash@gnu.org
Envelope-to	bug-bash@gnu.org
DKIM-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=case.edu; s=smtp-primary; t=1579101827; bh=kcyCIwbh5b10r5b6lhlQVRJBjdP/7IBmdBNm7jURK6I=; h=Reply-To:Cc:Subject:To:References:From:Message-ID:Date: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=qNYjVT0a9ZgEizhqH9Jcl7jxtlJhdL+9RvkvcH42LRfwfOiM/ucpqqco/sdHgzO6bf JqPbqsU0yzMTC36xkHHzblv2MbgzBW4SniDKVzQq47pu85nHbOgj9PeOZO/EblersMT 42JiRg0/lWX2/g7ZIgmp7KeT6o4p+Um0J2DMGiOtQXzsGpp2TqO/SA+S9SRjNElzQy2 4FTF9DhZ9uqN4s10eBJlUqPiIhNyqvx7k1j1OOCEC0WQMCSupHhuMYE11OdosrcbLFO Mq/8eyGKsYj6ORopt0FDgl2pzJFluoSs0+PHDYrdws6o6ic8I4wiDUlOl5yRJSiRhuC CXxS3tDg==
DKIM-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=case.edu; s=smtp-primary; t=1579101826; bh=9eUNICyDUJHlK+vlrmaTJsWX1NJ0NguMxok/Q9qb+KM=; h=Reply-To:Cc:Subject:To:References:From:Message-ID:Date: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=Ec32rv5DCsBEFvzHanrGkwdq+4N7G3EZCKpgVW5lQlMs8l4FZsHfTnx/vdHMQFKO9S Z3vHza+qQZFtCEwV+HHHjZHlo9yzWk9B7cEZurGRH1ZCP2b8EyGlm3gM1klg2+sQ5S8 wYv7nrtE0bdrz39svpeg7NvVjqWC7+iVOBDfHZOw2tKOCTsysWCf45S/7iM6Jklnrp+ WFVQ+z4/GwVKtCR8n/eH0/arMmZyzkjg/iv3PLeOeinEitdi/OS4JT++4Rrbdkb/3uL DIEpTjuc8o73TjBb51x2BbK3PnmS3IUHr+iXPGed8/J0GMQ4nky/R35w0LjYovQz2w7 +zupO2Pw==
User-Agent	Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.3.1
In-Reply-To	<CAFLRLk9R5wexNV53fx6-V3rQEwKExfJsoDanZ9JqGFatG9GnKg@mail.gmail.com>
Content-Language	en-US
X-Junkmail-Status	score=7/90, host=mpv1-2015.case.edu
X-Junkmail-PrAS-Raw	score=7/90, refid=2.7.2:2020.1.15.143617:17:7.944, ip=, rules=DKIM_SIGNATURE, __HAS_REPLYTO, __HAS_CC_HDR, __SUBJ_REPLY, __PHISH_SPEAR_SUBJ_ALERT, __BOUNCE_CHALLENGE_SUBJ, __BOUNCE_NDR_SUBJ_EXEMPT, __TO_MALFORMED_2, __TO_NAME, __TO_NAME_DIFF_FROM_ACC, __HAS_REFERENCES, __REFERENCES, __HAS_FROM, FROM_EDU_TLD, __HAS_MSGID, __SANE_MSGID, DATE_TZ_NA, __USER_AGENT, __MOZILLA_USER_AGENT, __MIME_VERSION, __IN_REP_TO, __CT, __CT_TEXT_PLAIN, __CTE, __REPLYTO_SAMEAS_FROM_ADDY, __REPLYTO_SAMEAS_FROM_ACC, __FROM_DOMAIN_IN_ANY_CC1, __FROM_DOMAIN_IN_ANY_CC2, __REPLYTO_SAMEAS_FROM_DOMAIN, __DKIM_ALIGNS_1, __DKIM_ALIGNS_2, __ANY_URI, __URI_MAILTO, __URI_WITH_PATH, __URI_NO_WWW, __CP_URI_IN_BODY, __SUBJ_ALPHA_NEGATE, __URI_IN_BODY, __URI_NOT_IMG, __MAIL_CHAIN, __FORWARDED_MSG, __BODY_NO_MAILTO, __NO_HTML_TAG_RAW, BODY_SIZE_700_799, BODYTEXTP_SIZE_3000_LESS, __MIME_TEXT_P1, __MIME_TEXT_ONLY, __URI_NS, [TRUNCATED], so=2010-03-03 19:42:08, dmn=2016-08-03-0138
X-detected-operating-system	by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] [fuzzy]
X-Received-From	129.22.103.226
X-BeenThere	bug-bash@gnu.org
X-Mailman-Version	2.1.23
Precedence	list
List-Id	Bug reports for the GNU Bourne Again SHell <bug-bash.gnu.org>
List-Unsubscribe	<https://lists.gnu.org/mailman/options/bug-bash>, <mailto:bug-bash-request@gnu.org?subject=unsubscribe>
List-Archive	<https://lists.gnu.org/archive/html/bug-bash>
List-Post	<mailto:bug-bash@gnu.org>
List-Help	<mailto:bug-bash-request@gnu.org?subject=help>
List-Subscribe	<https://lists.gnu.org/mailman/listinfo/bug-bash>, <mailto:bug-bash-request@gnu.org?subject=subscribe>
X-Mailman-Original-Message-ID	<59dee32e-2988-fe21-f5f6-5d722cf1e82a@case.edu>
X-Mailman-Original-References	<CAFLRLk9R5wexNV53fx6-V3rQEwKExfJsoDanZ9JqGFatG9GnKg@mail.gmail.com>
Xref	csiph.com gnu.bash.bug:15805

Show key headers only | View raw

On 12/18/19 11:43 AM, Koichi Murase wrote:

> Bash Version: 5.0
> Patch Level: 11
> Release Status: maint
> 
> Description:
> 
>    One of the public interface of readline, the function
>    `rl_bind_key (key, function)' does not work with key = 0 (C-@) when
>    there are already bindings of keyseqs starting from "\C-@".
>    This is because when `rl_bind_key' calls `rl_generic_bind',
>    it fails to construct an appropriate untranslated keyseq for "\C-@".

Thanks for the report and patches. I think your leak patches are correct.

Chet
-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
		 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    chet@case.edu    http://tiswww.cwru.edu/~chet/

Back to gnu.bash.bug | Previous | Next | Find similar

Thread

Re: [PATCH] Fix a problem `rl_bind_key' cannot create shadow binding for `C-@' Chet Ramey <chet.ramey@case.edu> - 2020-01-15 10:23 -0500

csiph-web