Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > comp.lang.python > #24643 > unrolled thread
| Started by | "Littlefield, Tyler" <tyler@tysdomain.com> |
|---|---|
| First post | 2012-06-28 20:57 -0600 |
| Last post | 2012-07-06 10:37 +0100 |
| Articles | 14 on this page of 134 — 34 participants |
Back to article view | Back to comp.lang.python
code review "Littlefield, Tyler" <tyler@tysdomain.com> - 2012-06-28 20:57 -0600
Re: code review alex23 <wuwei23@gmail.com> - 2012-06-28 20:58 -0700
Re: code review Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2012-06-29 07:31 +0000
Re: code review Chris Angelico <rosuav@gmail.com> - 2012-06-29 17:42 +1000
Re: code review "Littlefield, Tyler" <tyler@tysdomain.com> - 2012-06-29 09:03 -0600
Re: code review Alister <alister.ware@ntlworld.com> - 2012-06-29 19:41 +0000
Re: code review MRAB <python@mrabarnett.plus.com> - 2012-06-29 21:09 +0100
Re: code review "Martin P. Hellwig" <martin.hellwig@gmail.com> - 2012-06-29 13:27 -0700
Re: code review Alister <alister.ware@ntlworld.com> - 2012-06-29 20:43 +0000
Re: code review Dennis Lee Bieber <wlfraed@ix.netcom.com> - 2012-06-29 19:02 -0400
Re: code review Terry Reedy <tjreedy@udel.edu> - 2012-06-29 23:02 -0400
Re: code review "Littlefield, Tyler" <tyler@tysdomain.com> - 2012-06-29 14:49 -0600
Re: code review Alister <alister.ware@ntlworld.com> - 2012-06-30 09:31 +0000
Re: code review Alister <alister.ware@ntlworld.com> - 2012-06-30 09:36 +0000
Re: code review Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2012-06-30 02:28 +0000
Re: code review Alister <alister.ware@ntlworld.com> - 2012-06-30 09:22 +0000
Re: code review Terry Reedy <tjreedy@udel.edu> - 2012-06-29 23:00 -0400
Re: code review Alister <alister.ware@ntlworld.com> - 2012-06-30 10:04 +0000
Re: code review Peter Otten <__peter__@web.de> - 2012-06-30 12:29 +0200
Re: code review Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2012-06-30 20:39 +0200
Re: code review Thomas Jollans <t@jollybox.de> - 2012-06-30 21:38 +0200
Re: code review Alister <alister.ware@ntlworld.com> - 2012-06-30 20:30 +0000
Re: code review Thomas Jollans <t@jollybox.de> - 2012-06-30 22:50 +0200
Re: code review Alain Ketterlin <alain@dpt-info.u-strasbg.fr> - 2012-06-30 23:07 +0200
Re: code review Thomas Jollans <t@jollybox.de> - 2012-06-30 23:35 +0200
Re: code review Terry Reedy <tjreedy@udel.edu> - 2012-06-30 17:47 -0400
Re: code review Thomas Jollans <t@jollybox.de> - 2012-07-01 00:05 +0200
Re: code review Alain Ketterlin <alain@dpt-info.u-strasbg.fr> - 2012-07-01 01:03 +0200
Re: code review Ben Finney <ben+python@benfinney.id.au> - 2012-07-01 10:08 +1000
Re: code review Chris Angelico <rosuav@gmail.com> - 2012-07-01 10:37 +1000
Re: code review Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2012-07-01 03:23 +0000
Re: code review Chris Angelico <rosuav@gmail.com> - 2012-07-01 13:48 +1000
Re: code review Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2012-07-01 06:54 +0000
Re: code review Chris Angelico <rosuav@gmail.com> - 2012-07-01 16:59 +1000
Re: code review Terry Reedy <tjreedy@udel.edu> - 2012-07-01 05:55 -0400
Re: code review Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2012-07-02 01:26 +0000
Re: code review Albert van der Horst <albert@spenarnc.xs4all.nl> - 2012-07-13 12:30 +0000
Re: code review Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2012-07-13 15:04 +0000
Re: code review Chris Angelico <rosuav@gmail.com> - 2012-07-14 01:36 +1000
Re: code review rusi <rustompmody@gmail.com> - 2012-07-13 09:24 -0700
Re: code review Dennis Lee Bieber <wlfraed@ix.netcom.com> - 2012-07-13 16:39 -0400
Re: code review Duncan Booth <duncan.booth@invalid.invalid> - 2012-07-16 10:43 +0000
Re: code review Ben Finney <ben+python@benfinney.id.au> - 2012-07-16 21:34 +1000
Re: code review Albert van der Horst <albert@spenarnc.xs4all.nl> - 2012-07-17 10:54 +0000
Re: code review Terry Reedy <tjreedy@udel.edu> - 2012-07-13 19:09 -0400
Re: code review Ian Kelly <ian.g.kelly@gmail.com> - 2012-07-14 03:26 -0600
Re: code review Terry Reedy <tjreedy@udel.edu> - 2012-07-14 16:42 -0400
Re: code review rusi <rustompmody@gmail.com> - 2012-06-30 21:07 -0700
Re: code review Chris Angelico <rosuav@gmail.com> - 2012-07-01 14:20 +1000
Re: code review Ben Finney <ben+python@benfinney.id.au> - 2012-07-01 17:28 +1000
Re: code review Thomas Jollans <t@jollybox.de> - 2012-07-01 09:46 +0200
Re: code review HoneyMonster <nobody@someplace.invalid> - 2012-07-01 20:53 +0000
Re: code review Devin Jeanpierre <jeanpierreda@gmail.com> - 2012-07-01 05:18 -0400
Re: code review Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2012-07-02 00:41 +0000
Re: code review Devin Jeanpierre <jeanpierreda@gmail.com> - 2012-07-01 21:40 -0400
Re: code review Dennis Lee Bieber <wlfraed@ix.netcom.com> - 2012-07-01 13:41 -0400
Re: code review John O'Hagan <research@johnohagan.com> - 2012-07-02 14:43 +1000
Re: Re: code review Evan Driscoll <driscoll@cs.wisc.edu> - 2012-06-30 23:45 -0500
Re: Re: code review Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2012-07-01 08:57 +0200
Re: code review Alister <alister.ware@ntlworld.com> - 2012-07-01 09:54 +0000
Re: Re: code review Evan Driscoll <driscoll@cs.wisc.edu> - 2012-07-01 10:48 -0500
Re: Re: code review lars van gemerden <lars@rational-it.com> - 2012-07-06 04:22 -0700
Re: Re: code review lars van gemerden <lars@rational-it.com> - 2012-07-06 04:22 -0700
Re: code review Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2012-07-06 13:58 +0000
Re: code review Roy Smith <roy@panix.com> - 2012-07-13 08:32 -0700
Re: code review Evan Driscoll <driscoll@cs.wisc.edu> - 2012-06-30 23:57 -0500
Re: code review Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2012-07-01 09:04 +0200
Re: code review Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2012-07-01 02:06 +0000
Re: code review Chris Angelico <rosuav@gmail.com> - 2012-07-01 12:20 +1000
Re: code review Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2012-07-01 04:17 +0000
Re: code review Chris Angelico <rosuav@gmail.com> - 2012-07-01 14:23 +1000
Re: code review Steven D'Aprano <steve+usenet@pearwood.info> - 2012-07-01 06:27 +0000
Re: code review Chris Angelico <rosuav@gmail.com> - 2012-07-01 16:33 +1000
Re: code review Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2012-07-02 01:28 +0000
Re: code review Devin Jeanpierre <jeanpierreda@gmail.com> - 2012-07-01 21:50 -0400
Re: code review Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2012-07-02 07:29 +0000
Re: code review Chris Angelico <rosuav@gmail.com> - 2012-07-02 12:04 +1000
Re: code review Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2012-07-02 08:11 +0000
Re: code review Chris Angelico <rosuav@gmail.com> - 2012-07-02 18:20 +1000
Re: code review Rick Johnson <rantingrickjohnson@gmail.com> - 2012-07-02 08:57 -0700
Re: code review Chris Angelico <rosuav@gmail.com> - 2012-07-03 02:42 +1000
Re: code review Rick Johnson <rantingrickjohnson@gmail.com> - 2012-07-02 11:22 -0700
Re: code review Thomas Jollans <t@jollybox.de> - 2012-07-02 21:06 +0200
Re: code review Rick Johnson <rantingrickjohnson@gmail.com> - 2012-07-02 12:35 -0700
Re: code review Chris Angelico <rosuav@gmail.com> - 2012-07-03 07:57 +1000
Re: code review Neil Cerutti <neilc@norwich.edu> - 2012-07-03 12:19 +0000
Re: code review Dennis Lee Bieber <wlfraed@ix.netcom.com> - 2012-07-02 01:20 -0400
Re: code review Thomas Jollans <t@jollybox.de> - 2012-07-02 16:41 +0200
Re: code review Terry Reedy <tjreedy@udel.edu> - 2012-07-02 11:33 -0400
Re: code review Thomas Jollans <t@jollybox.de> - 2012-07-01 09:35 +0200
Re: code review Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2012-07-02 00:43 +0000
Re: code review Thomas Jollans <t@jollybox.de> - 2012-07-02 16:26 +0200
Re: code review Rick Johnson <rantingrickjohnson@gmail.com> - 2012-07-02 08:16 -0700
Re: code review Chris Angelico <rosuav@gmail.com> - 2012-07-03 02:55 +1000
Re: code review Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2012-07-03 00:57 +0000
Re: code review Chris Angelico <rosuav@gmail.com> - 2012-07-03 11:22 +1000
Re: code review John O'Hagan <research@johnohagan.com> - 2012-07-03 12:25 +1000
Re: code review Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2012-07-03 04:11 +0000
Re: code review Dennis Lee Bieber <wlfraed@ix.netcom.com> - 2012-07-03 02:09 -0400
Re: code review Roy Smith <roy@panix.com> - 2012-07-03 08:33 -0400
Re: code review Mark Lawrence <breamoreboy@yahoo.co.uk> - 2012-07-03 16:53 +0100
Re: code review Dennis Lee Bieber <wlfraed@ix.netcom.com> - 2012-07-03 17:32 -0400
Re: code review rusi <rustompmody@gmail.com> - 2012-07-02 22:10 -0700
Re: code review Ben Finney <ben+python@benfinney.id.au> - 2012-07-03 15:46 +1000
Re: code review John O'Hagan <research@johnohagan.com> - 2012-07-04 00:59 +1000
Re: code review Mark Lawrence <breamoreboy@yahoo.co.uk> - 2012-07-03 16:50 +0100
Re: code review Paul Rudin <paul.nospam@rudin.co.uk> - 2012-07-04 10:29 +0100
Re: code review Mark Lawrence <breamoreboy@yahoo.co.uk> - 2012-07-04 17:25 +0100
Re: code review Chris Angelico <rosuav@gmail.com> - 2012-07-04 01:53 +1000
Re: code review Mark Lawrence <breamoreboy@yahoo.co.uk> - 2012-07-03 17:05 +0100
Re: code review Dave Angel <d@davea.name> - 2012-07-03 16:13 -0400
Re: code review Chris Angelico <rosuav@gmail.com> - 2012-07-04 07:54 +1000
Re: code review Mark Lawrence <breamoreboy@yahoo.co.uk> - 2012-07-04 09:28 +0100
Re: code review rusi <rustompmody@gmail.com> - 2012-06-30 19:37 -0700
Re: code review Chris Angelico <rosuav@gmail.com> - 2012-07-01 09:25 +1000
Re: code review Thomas Jollans <t@jollybox.de> - 2012-07-01 01:50 +0200
Re: code review "Martin P. Hellwig" <martin.hellwig@gmail.com> - 2012-06-30 14:48 -0700
Re: code review Ian Kelly <ian.g.kelly@gmail.com> - 2012-07-02 13:16 -0600
Re: code review Alister <alister.ware@ntlworld.com> - 2012-06-30 20:25 +0000
Re: code review Kushal Kumaran <kushal.kumaran+python@gmail.com> - 2012-07-03 23:23 +0530
Re: code review John Gordon <gordon@panix.com> - 2012-07-03 18:18 +0000
Re: code review Ian Kelly <ian.g.kelly@gmail.com> - 2012-07-03 12:27 -0600
Re: code review Chris Angelico <rosuav@gmail.com> - 2012-07-04 07:51 +1000
Re: code review Ian Kelly <ian.g.kelly@gmail.com> - 2012-07-03 12:19 -0600
Re: code review kushal.kumaran+python@gmail.com - 2012-07-04 08:27 +0530
Re: code review Chris Angelico <rosuav@gmail.com> - 2012-07-04 13:53 +1000
Re: code review Simon Cropper <simoncropper@fossworkflowguides.com> - 2012-07-04 14:55 +1000
Re: code review "Littlefield, Tyler" <tyler@tysdomain.com> - 2012-07-03 23:39 -0600
Re: code review alex23 <wuwei23@gmail.com> - 2012-07-03 23:17 -0700
Re: code review rusi <rustompmody@gmail.com> - 2012-07-04 00:05 -0700
Apology for OT posts (was: code review) John O'Hagan <research@johnohagan.com> - 2012-07-06 12:06 +1000
Re: Apology for OT posts Simon Cropper <simoncropper@fossworkflowguides.com> - 2012-07-06 15:30 +1000
Re: Apology for OT posts Chris Angelico <rosuav@gmail.com> - 2012-07-06 17:45 +1000
Re: Apology for OT posts Mark Lawrence <breamoreboy@yahoo.co.uk> - 2012-07-06 10:37 +0100
Page 7 of 7 — ← Prev page 1 2 3 4 5 6 [7]
| From | John Gordon <gordon@panix.com> |
|---|---|
| Date | 2012-07-03 18:18 +0000 |
| Message-ID | <jsvd15$86m$1@reader1.panix.com> |
| In reply to | #24827 |
In <mailman.1753.1341338042.4697.python-list@python.org> Kushal Kumaran <kushal.kumaran+python@gmail.com> writes:
> I haven't actually seen the rest of the code, but I would like to
> point out that applications placing maximum length limits on passwords
> are extremely annoying.
As a practical matter, doesn't there have to be *some* sort of limit?
For example if the (encrypted) password is stored in a database, you can't
exceed the table column width.
--
John Gordon A is for Amy, who fell down the stairs
gordon@panix.com B is for Basil, assaulted by bears
-- Edward Gorey, "The Gashlycrumb Tinies"
[toc] | [prev] | [next] | [standalone]
| From | Ian Kelly <ian.g.kelly@gmail.com> |
|---|---|
| Date | 2012-07-03 12:27 -0600 |
| Message-ID | <mailman.1755.1341340058.4697.python-list@python.org> |
| In reply to | #24828 |
On Tue, Jul 3, 2012 at 12:18 PM, John Gordon <gordon@panix.com> wrote: > In <mailman.1753.1341338042.4697.python-list@python.org> Kushal Kumaran <kushal.kumaran+python@gmail.com> writes: > >> I haven't actually seen the rest of the code, but I would like to >> point out that applications placing maximum length limits on passwords >> are extremely annoying. > > As a practical matter, doesn't there have to be *some* sort of limit? > For example if the (encrypted) password is stored in a database, you can't > exceed the table column width. Hopefully you're storing password hashes, not encrypted passwords (which can all too easily be DEcrypted), and the length of the hash is not dependent on the length of the password. But yes, there are certainly practical concerns here.
[toc] | [prev] | [next] | [standalone]
| From | Chris Angelico <rosuav@gmail.com> |
|---|---|
| Date | 2012-07-04 07:51 +1000 |
| Message-ID | <mailman.1761.1341352280.4697.python-list@python.org> |
| In reply to | #24828 |
On Wed, Jul 4, 2012 at 4:27 AM, Ian Kelly <ian.g.kelly@gmail.com> wrote: > On Tue, Jul 3, 2012 at 12:18 PM, John Gordon <gordon@panix.com> wrote: >> As a practical matter, doesn't there have to be *some* sort of limit? >> For example if the (encrypted) password is stored in a database, you can't >> exceed the table column width. > > Hopefully you're storing password hashes, not encrypted passwords > (which can all too easily be DEcrypted), and the length of the hash is > not dependent on the length of the password. But yes, there are > certainly practical concerns here. With a hash length of N bits, there's not much use accepting passwords longer than about N/4 or N/2 bytes. (It would be N/8 except that most people don't invent passwords that use the entire available alphabet. And of course, this ignores issues of encodings, but I'm pretty sure all current crypto hashes work with bytes not characters anyway.) But please, don't limit password lengths too much. Make your password system XKCD 936 compliant: http://xkcd.com/936/ Permit long passwords consisting of nothing but lowercase letters. They really aren't as insecure as some people think! ChrisA
[toc] | [prev] | [next] | [standalone]
| From | Ian Kelly <ian.g.kelly@gmail.com> |
|---|---|
| Date | 2012-07-03 12:19 -0600 |
| Message-ID | <mailman.1754.1341339597.4697.python-list@python.org> |
| In reply to | #24692 |
On Tue, Jul 3, 2012 at 11:53 AM, Kushal Kumaran <kushal.kumaran+python@gmail.com> wrote: > On Sat, Jun 30, 2012 at 3:34 PM, Alister <alister.ware@ntlworld.com> wrote: >> On Fri, 29 Jun 2012 09:03:22 -0600, Littlefield, Tyler wrote: >> >>> On 6/29/2012 1:31 AM, Steven D'Aprano wrote: >>>> On Thu, 28 Jun 2012 20:58:15 -0700, alex23 wrote: >>>> >>>>> On Jun 29, 12:57 pm, "Littlefield, Tyler" <ty...@tysdomain.com> wrote: >>>>>> I was curious if someone wouldn't mind poking at some code. The >>>>>> project page is at:http://code.google.com/p/pymud Any information is >>>>>> greatly appreciated. >>>>> I couldn't find any actual code at that site, the git repository is >>>>> currently empty. >>> >>> OOPS, sorry. Apparently I'm not as good with git as I thought. >>> Everything's in the repo now. >> >> I think I may be on firmer grounds with the next few: >> >> isValidPassword can be simplified to >> >> def isValidPassword(password: >> count=len(password) >> return count>= mud.minpass and count<= mud.maxpass >> > > I haven't actually seen the rest of the code, but I would like to > point out that applications placing maximum length limits on passwords > are extremely annoying. They're annoying when the maximum length is unreasonably small, but you have to have a maximum length to close off one DoS attack vector. Without a limit, if a "user" presents a 1 GB password, then guess what? Your system has to hash that GB of data before it can reject it. And if you're serious about security then it will be a cryptographic hash, and that means slow. To prevent that, the system needs to reject outright password attempts that are longer than some predetermined reasonable length, and if the system won't authenticate those passwords, then it can't allow the user to set them either. Cheers, Ian
[toc] | [prev] | [next] | [standalone]
| From | kushal.kumaran+python@gmail.com |
|---|---|
| Date | 2012-07-04 08:27 +0530 |
| Message-ID | <mailman.1770.1341370664.4697.python-list@python.org> |
| In reply to | #24692 |
Ian Kelly <ian.g.kelly@gmail.com> wrote: >On Tue, Jul 3, 2012 at 11:53 AM, Kushal Kumaran ><kushal.kumaran+python@gmail.com> wrote: >> On Sat, Jun 30, 2012 at 3:34 PM, Alister <alister.ware@ntlworld.com> >wrote: >>> On Fri, 29 Jun 2012 09:03:22 -0600, Littlefield, Tyler wrote: >>> >>>> On 6/29/2012 1:31 AM, Steven D'Aprano wrote: >>>>> On Thu, 28 Jun 2012 20:58:15 -0700, alex23 wrote: >>>>> >>>>>> On Jun 29, 12:57 pm, "Littlefield, Tyler" <ty...@tysdomain.com> >wrote: >>>>>>> I was curious if someone wouldn't mind poking at some code. The >>>>>>> project page is at:http://code.google.com/p/pymud Any >information is >>>>>>> greatly appreciated. >>>>>> I couldn't find any actual code at that site, the git repository >is >>>>>> currently empty. >>>> >>>> OOPS, sorry. Apparently I'm not as good with git as I thought. >>>> Everything's in the repo now. >>> >>> I think I may be on firmer grounds with the next few: >>> >>> isValidPassword can be simplified to >>> >>> def isValidPassword(password: >>> count=len(password) >>> return count>= mud.minpass and count<= mud.maxpass >>> >> >> I haven't actually seen the rest of the code, but I would like to >> point out that applications placing maximum length limits on >passwords >> are extremely annoying. > >They're annoying when the maximum length is unreasonably small, but >you have to have a maximum length to close off one DoS attack vector. >Without a limit, if a "user" presents a 1 GB password, then guess >what? Your system has to hash that GB of data before it can reject >it. And if you're serious about security then it will be a >cryptographic hash, and that means slow. > Well, if you waited until you had the password (however long) in a variable before you applied your maximum limits, the DoS ship has probably sailed already. >To prevent that, the system needs to reject outright password attempts >that are longer than some predetermined reasonable length, and if the >system won't authenticate those passwords, then it can't allow the >user to set them either. > >Cheers, >Ian -- regards, kushal
[toc] | [prev] | [next] | [standalone]
| From | Chris Angelico <rosuav@gmail.com> |
|---|---|
| Date | 2012-07-04 13:53 +1000 |
| Message-ID | <mailman.1771.1341374040.4697.python-list@python.org> |
| In reply to | #24692 |
On Wed, Jul 4, 2012 at 12:57 PM, <kushal.kumaran+python@gmail.com> wrote: > Well, if you waited until you had the password (however long) in a variable before you applied your maximum limits, the DoS ship has probably sailed already. Only because data transfer is usually more expensive than hashing. But I'd say that'll always be true. ChrisA
[toc] | [prev] | [next] | [standalone]
| From | Simon Cropper <simoncropper@fossworkflowguides.com> |
|---|---|
| Date | 2012-07-04 14:55 +1000 |
| Message-ID | <mailman.1775.1341377755.4697.python-list@python.org> |
| In reply to | #24692 |
On 04/07/12 13:53, Chris Angelico wrote: > On Wed, Jul 4, 2012 at 12:57 PM, <kushal.kumaran+python@gmail.com> wrote: >> Well, if you waited until you had the password (however long) in a variable before you applied your maximum limits, the DoS ship has probably sailed already. > > Only because data transfer is usually more expensive than hashing. But > I'd say that'll always be true. > > ChrisA > Some questions to Tyler Littlefield, who started this thread. Q1 -- Did you get any constructive feedback on your code? Q2 -- Did you feel that the process of submitting your code for review met your expectation? Q3 -- Would you recommend others doing this either on this forum or other fora? It appears to me - third party watching the ongoing dialog - that the tread has gone right off topic (some time ago) and someone should really start a new thread under a new title/subject. Most of what I have read does not appear to be discussing your code or how you could improve your code. Following the last few posts, I was wondering whether some other off-list dialog is going on or whether I am missing something. -- Cheers Simon
[toc] | [prev] | [next] | [standalone]
| From | "Littlefield, Tyler" <tyler@tysdomain.com> |
|---|---|
| Date | 2012-07-03 23:39 -0600 |
| Message-ID | <mailman.1776.1341380373.4697.python-list@python.org> |
| In reply to | #24692 |
On 7/3/2012 10:55 PM, Simon Cropper wrote: > Some questions to Tyler Littlefield, who started this thread. > > Q1 -- Did you get any constructive feedback on your code? I did get some, which I appreciated. someone mentioned using PyLint. From reading, I found it was really really pedantic, so I used PyFlakes instead. > > Q2 -- Did you feel that the process of submitting your code for review > met your expectation? There wasn't much more to review, so yes. The info I got was helpful and farther than it was before I started. > Q3 -- Would you recommend others doing this either on this forum or > other fora? > > It appears to me - third party watching the ongoing dialog - that the > tread has gone right off topic (some time ago) and someone should > really start a new thread under a new title/subject. Most of what I > have read does not appear to be discussing your code or how you could > improve your code. > I basically just stopped after a while. It got into a my language is better than your language, so I didn't see much constructive info. I've started reading from the bottom though, where it looks like it's back, and I do appreciate the rest of the info given, as well. Thanks again for the feedback. > Following the last few posts, I was wondering whether some other > off-list dialog is going on or whether I am missing something. > -- Take care, Ty http://tds-solutions.net The aspen project: a barebones light-weight mud engine: http://code.google.com/p/aspenmud He that will not reason is a bigot; he that cannot reason is a fool; he that dares not reason is a slave.
[toc] | [prev] | [next] | [standalone]
| From | alex23 <wuwei23@gmail.com> |
|---|---|
| Date | 2012-07-03 23:17 -0700 |
| Message-ID | <b3ed25d6-43e1-494f-8131-8a1c7923e5ce@si8g2000pbc.googlegroups.com> |
| In reply to | #24848 |
On Jul 4, 3:39 pm, "Littlefield, Tyler" <ty...@tysdomain.com> wrote: > I basically just stopped after a while. It got into a my language is > better than your language, so I didn't see much constructive info. To be fair, it's more "my vision of the language is better than yours" :) But yes, it should've been forked into a separate thread ages okay. It did get me wondering, though, if there's much in the way of support for code review in repository sites like github? Being able to aggregate comments around the actual code itself could be really handy.
[toc] | [prev] | [next] | [standalone]
| From | rusi <rustompmody@gmail.com> |
|---|---|
| Date | 2012-07-04 00:05 -0700 |
| Message-ID | <0e9822e4-51e2-4f33-acb6-deb9248a6e3b@q5g2000pba.googlegroups.com> |
| In reply to | #24849 |
On Jul 4, 11:17 am, alex23 <wuwe...@gmail.com> wrote: > On Jul 4, 3:39 pm, "Littlefield, Tyler" <ty...@tysdomain.com> wrote: > > > I basically just stopped after a while. It got into a my language is > > better than your language, so I didn't see much constructive info. > > To be fair, it's more "my vision of the language is better than > yours" :) But yes, it should've been forked into a separate thread > ages okay. A program is a product of a person's creativity as is a programming language. They have an analogous relation as say a sculpture to chisels. This thread is a good example of how longwindedness of a discussion correlates with its uselessness. However the reverse error is more insidious: programs are made by humans and should be critiqued, whereas programming languages (in particular python) is sacrosanct and cannot be questioned. Too often I find that responders on this list treat as personal affront anyone who questions python whereas the most appropriate response would be: Nice idea but too invasive for serious consideration. [I am saying this in general and not for this thread:Whats wrong with a < b < c is quite beyond me!] > > It did get me wondering, though, if there's much in the way of support > for code review in repository sites like github? Being able to > aggregate comments around the actual code itself could be really > handy.
[toc] | [prev] | [next] | [standalone]
| From | John O'Hagan <research@johnohagan.com> |
|---|---|
| Date | 2012-07-06 12:06 +1000 |
| Subject | Apology for OT posts (was: code review) |
| Message-ID | <mailman.1845.1341540406.4697.python-list@python.org> |
| In reply to | #24692 |
On Tue, 03 Jul 2012 23:39:20 -0600 "Littlefield, Tyler" <tyler@tysdomain.com> wrote: > On 7/3/2012 10:55 PM, Simon Cropper wrote: > > Some questions to Tyler Littlefield, who started this thread. > > > > Q1 -- Did you get any constructive feedback on your code? > > I did get some, which I appreciated. someone mentioned using PyLint. > From reading, I found it was really really pedantic, so I used PyFlakes > instead. > > > > Q2 -- Did you feel that the process of submitting your code for review > > met your expectation? > > There wasn't much more to review, so yes. The info I got was helpful and > farther than it was before I started. > > > Q3 -- Would you recommend others doing this either on this forum or > > other fora? > > > > It appears to me - third party watching the ongoing dialog - that the > > tread has gone right off topic (some time ago) and someone should > > really start a new thread under a new title/subject. Most of what I > > have read does not appear to be discussing your code or how you could > > improve your code. > > > I basically just stopped after a while. It got into a my language is > better than your language, so I didn't see much constructive info. I've > started reading from the bottom though, where it looks like it's back, > and I do appreciate the rest of the info given, as well. Thanks again > for the feedback. > As one of the perpetrators, I did apologise for being OT within the body of my replies to OT posts, but I see the irony. I guess I just thought somebody else would do it eventually. I hereby apologise for not taking the correct action, and vow to do so in future: to change the subject line regardless of who initially went OT, starting now. Regards, -- John
[toc] | [prev] | [next] | [standalone]
| From | Simon Cropper <simoncropper@fossworkflowguides.com> |
|---|---|
| Date | 2012-07-06 15:30 +1000 |
| Subject | Re: Apology for OT posts |
| Message-ID | <mailman.1850.1341552670.4697.python-list@python.org> |
| In reply to | #24692 |
On 06/07/12 12:06, John O'Hagan wrote: > On Tue, 03 Jul 2012 23:39:20 -0600 > "Littlefield, Tyler" <tyler@tysdomain.com> wrote: > >> On 7/3/2012 10:55 PM, Simon Cropper wrote: >>> Some questions to Tyler Littlefield, who started this thread. >>> >>> Q1 -- Did you get any constructive feedback on your code? >> >> I did get some, which I appreciated. someone mentioned using PyLint. >> From reading, I found it was really really pedantic, so I used PyFlakes >> instead. >>> >>> Q2 -- Did you feel that the process of submitting your code for review >>> met your expectation? >> >> There wasn't much more to review, so yes. The info I got was helpful and >> farther than it was before I started. >> >>> Q3 -- Would you recommend others doing this either on this forum or >>> other fora? >>> >>> It appears to me - third party watching the ongoing dialog - that the >>> tread has gone right off topic (some time ago) and someone should >>> really start a new thread under a new title/subject. Most of what I >>> have read does not appear to be discussing your code or how you could >>> improve your code. >>> >> I basically just stopped after a while. It got into a my language is >> better than your language, so I didn't see much constructive info. I've >> started reading from the bottom though, where it looks like it's back, >> and I do appreciate the rest of the info given, as well. Thanks again >> for the feedback. >> > > As one of the perpetrators, I did apologise for being OT within the body of my > replies to OT posts, but I see the irony. I guess I just thought somebody else > would do it eventually. I hereby apologise for not taking the correct action, > and vow to do so in future: to change the subject line regardless of who > initially went OT, starting now. > > Regards, > -- > John > thanks :) bet this kills the conservation though... Simon
[toc] | [prev] | [next] | [standalone]
| From | Chris Angelico <rosuav@gmail.com> |
|---|---|
| Date | 2012-07-06 17:45 +1000 |
| Subject | Re: Apology for OT posts |
| Message-ID | <mailman.1855.1341560748.4697.python-list@python.org> |
| In reply to | #24692 |
On Fri, Jul 6, 2012 at 3:30 PM, Simon Cropper <simoncropper@fossworkflowguides.com> wrote: > bet this kills the conservation though... Probably. Until someone trolls the list again and sets us all going... I'm another of the worst perps, so in the words of Pooh-Bah, "I desire to associate myself with that expression of regret". It was a pretty good discussion actually. The only real problem was the subject line. ChrisA
[toc] | [prev] | [next] | [standalone]
| From | Mark Lawrence <breamoreboy@yahoo.co.uk> |
|---|---|
| Date | 2012-07-06 10:37 +0100 |
| Subject | Re: Apology for OT posts |
| Message-ID | <mailman.1857.1341567453.4697.python-list@python.org> |
| In reply to | #24692 |
On 06/07/2012 08:45, Chris Angelico wrote: > On Fri, Jul 6, 2012 at 3:30 PM, Simon Cropper > <simoncropper@fossworkflowguides.com> wrote: >> bet this kills the conservation though... > > Probably. Until someone trolls the list again and sets us all going... > > I'm another of the worst perps, so in the words of Pooh-Bah, "I desire > to associate myself with that expression of regret". > > It was a pretty good discussion actually. The only real problem was > the subject line. > > ChrisA > As far as I'm concerned nothing is OT here unless it is blatant trolling or spamming. It makes for a far more interesting read than the groups that have a policy of "if it's not in the standard, we won't discuss it". The set of languages that start with the third letter of the English language springs instantly to my mind. Agreed that the subject line should be changed. -- Cheers. Mark Lawrence.
[toc] | [prev] | [standalone]
Page 7 of 7 — ← Prev page 1 2 3 4 5 6 [7]
Back to top | Article view | comp.lang.python
csiph-web