Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > comp.lang.python > #29764 > unrolled thread

request for another code review

Started by"Littlefield, Tyler" <tyler@tysdomain.com>
First post2012-09-22 14:13 -0600
Last post2012-09-24 15:08 -0600
Articles 4 — 2 participants

Back to article view | Back to comp.lang.python


Contents

  request for another code review "Littlefield, Tyler" <tyler@tysdomain.com> - 2012-09-22 14:13 -0600
    Re: request for another code review alex23 <wuwei23@gmail.com> - 2012-09-23 20:48 -0700
      Re: request for another code review "Littlefield, Tyler" <tyler@tysdomain.com> - 2012-09-24 15:08 -0600
      Re: request for another code review "Littlefield, Tyler" <tyler@tysdomain.com> - 2012-09-24 15:08 -0600

#29764 — request for another code review

From"Littlefield, Tyler" <tyler@tysdomain.com>
Date2012-09-22 14:13 -0600
Subjectrequest for another code review
Message-ID<mailman.1089.1348344861.27098.python-list@python.org>
Hello all:
I've gotten a bit farther into my python mud, and wanted to request 
another code review for style and the like. Mainly I'm concerned about 
player.py, world.py and components and other ways to handle what I'm 
trying to do.
I didn't run pychecker just yet, so there are probably a ton of syntax 
errors; my problem was that world was importing room, and room imported 
world for functionality and that made things a mess.
Ideas and suggestions for code cleanup and cleaner ways to do things 
would be appreciated.
git clone https://code.google.com/p/pymud/
Thanks,

-- 
Take care,
Ty
http://tds-solutions.net
The aspen project: a barebones light-weight mud engine:
http://code.google.com/p/aspenmud
He that will not reason is a bigot; he that cannot reason is a fool; he that dares not reason is a slave.

[toc] | [next] | [standalone]


#29890

Fromalex23 <wuwei23@gmail.com>
Date2012-09-23 20:48 -0700
Message-ID<e3ceed75-7c19-44b7-b1ea-510c3dea3772@ph9g2000pbb.googlegroups.com>
In reply to#29764
On Sep 23, 6:14 am, "Littlefield, Tyler" <ty...@tysdomain.com> wrote:
> I've gotten a bit farther into my python mud, and wanted to request
> another code review for style and the like.

Are you familiar with codereview.stackexchange.com ?

(This isn't to dissuade you from posting such requests here, just to
help increase the chance of eyeballs on your code.)

[toc] | [prev] | [next] | [standalone]


#29929

From"Littlefield, Tyler" <tyler@tysdomain.com>
Date2012-09-24 15:08 -0600
Message-ID<mailman.1211.1348520912.27098.python-list@python.org>
In reply to#29890
On 9/23/2012 9:48 PM, alex23 wrote:
> On Sep 23, 6:14 am, "Littlefield, Tyler" <ty...@tysdomain.com> wrote:
>> I've gotten a bit farther into my python mud, and wanted to request
>> another code review for style and the like.
> Are you familiar with codereview.stackexchange.com ?

> I actually wasn't, thanks!

> (This isn't to dissuade you from posting such requests here, just to
> help increase the chance of eyeballs on your code.)


-- 
Take care,
Ty
http://tds-solutions.net
The aspen project: a barebones light-weight mud engine:
http://code.google.com/p/aspenmud
He that will not reason is a bigot; he that cannot reason is a fool; he that dares not reason is a slave.

[toc] | [prev] | [next] | [standalone]


#29930

From"Littlefield, Tyler" <tyler@tysdomain.com>
Date2012-09-24 15:08 -0600
Message-ID<mailman.1212.1348520918.27098.python-list@python.org>
In reply to#29890
On 9/23/2012 9:48 PM, alex23 wrote:
> On Sep 23, 6:14 am, "Littlefield, Tyler" <ty...@tysdomain.com> wrote:
>> I've gotten a bit farther into my python mud, and wanted to request
>> another code review for style and the like.
> Are you familiar with codereview.stackexchange.com ?

> I actually wasn't, thanks!

> (This isn't to dissuade you from posting such requests here, just to
> help increase the chance of eyeballs on your code.)


-- 
Take care,
Ty
http://tds-solutions.net
The aspen project: a barebones light-weight mud engine:
http://code.google.com/p/aspenmud
He that will not reason is a bigot; he that cannot reason is a fool; he that dares not reason is a slave.

[toc] | [prev] | [standalone]


Back to top | Article view | comp.lang.python


csiph-web