Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.python > #64197

Re: [newbie] advice and comment wanted on first tkinter program

Show key headers only | View raw

On 1/17/2014 8:20 AM, Jean Dupont wrote:
> Dear all,
> I made a simple gui with tkinter. I can imagine there are things which I
> did which are "not optimal". So what I ask is to comment on my code
> preferable with snippets of code which show how to do improve my code.
> #!/usr/bin/env python
> import Tkinter

1. import Tkinter as tk

Besides saving a bit of writing and reading time later, this makes any 
future conversion to 3.x easier.

import tkinter as tk

2. add a few spaces to demarcate blocks of code.

> import time
> import RPi.GPIO as GPIO

2. add a few spaces to demarcate blocks of code, such as here

> GPIO.setmode(GPIO.BOARD)
> GPIO.setup(26,GPIO.OUT)
> GPIO.setup(24,GPIO.OUT)
> #hardware : connect 2 leds:
> #board-pin 26 on/off led; control with buttons
> #board-pin 24 led with pwm dimming and frequency; control via sliders

and here

> top = Tkinter.Tk()
> top.geometry("600x400+310+290")

This looks strange somehow, but if it works...


> label1 = Label(top,relief=RAISED,bg =
> "#EFF980",font=("Helvetica",14),height = 1, width = 15)

In calls, put spaces after , but not before and after =.
For other suggestions, see
http://www.python.org/dev/peps/pep-0008/

I suspect that the above is one line in your code and the bad wrapping a 
result of mis-spacing. The following is also one line, but easer to read 
as spaces separate argument chunks

label1 = Label(top, relief=RAISED, bg="#EFF980", font=("Helvetica",14), 
height=1, width=15)

and the wrapping, if any, does not break up an arg chunk.

Some people advocate defining an App class, but Tk and tkinter, even 
though object method based, allow the straightforward imperative style 
you have used.

I agree with Peter: "First and foremost a program has to do what the 
author wants it to do. Everything else is secondary." But a bit of 
styling will make reading and changing easier.

-- 
Terry Jan Reedy

Back to comp.lang.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[newbie] advice and comment wanted on first tkinter program Jean Dupont <jeandupont115@gmail.com> - 2014-01-17 05:20 -0800
  Re: [newbie] advice and comment wanted on first tkinter program Peter Otten <__peter__@web.de> - 2014-01-17 16:17 +0100
  Re: [newbie] advice and comment wanted on first tkinter program Terry Reedy <tjreedy@udel.edu> - 2014-01-17 16:40 -0500
    Re: [newbie] advice and comment wanted on first tkinter program Jean Dupont <jeandupont314@gmail.com> - 2014-01-18 06:52 -0800
      Re: [newbie] advice and comment wanted on first tkinter program Oscar Benjamin <oscar.j.benjamin@gmail.com> - 2014-01-18 15:12 +0000
        Re: [newbie] advice and comment wanted on first tkinter program Jean Dupont <jeandupont314@gmail.com> - 2014-01-19 20:04 -0800
          Re: [newbie] advice and comment wanted on first tkinter program Chris Angelico <rosuav@gmail.com> - 2014-01-20 17:24 +1100
            Re: [newbie] advice and comment wanted on first tkinter program Jean Dupont <jeandupont314@gmail.com> - 2014-01-21 23:23 -0800
              Re: [newbie] advice and comment wanted on first tkinter program Dave Angel <davea@davea.name> - 2014-01-22 07:08 -0500
          Re: [newbie] advice and comment wanted on first tkinter program Alister <alister.ware@ntlworld.com> - 2014-01-20 09:17 +0000
            Re: [newbie] advice and comment wanted on first tkinter program Jean Dupont <jeandupont115@gmail.com> - 2014-01-22 06:45 -0800
              Re: [newbie] advice and comment wanted on first tkinter program Alister <alister.ware@ntlworld.com> - 2014-01-22 15:43 +0000
                Re: [newbie] advice and comment wanted on first tkinter program Jean Dupont <jeandupont115@gmail.com> - 2014-01-27 00:23 -0800
              Re: [newbie] advice and comment wanted on first tkinter program Jean Dupont <jeandupont115@gmail.com> - 2014-01-27 00:28 -0800
      Re: [newbie] advice and comment wanted on first tkinter program Mark Lawrence <breamoreboy@yahoo.co.uk> - 2014-01-18 16:15 +0000
      Re: [newbie] advice and comment wanted on first tkinter program Dennis Lee Bieber <wlfraed@ix.netcom.com> - 2014-01-18 12:28 -0500
      Re: [newbie] advice and comment wanted on first tkinter program Dennis Lee Bieber <wlfraed@ix.netcom.com> - 2014-01-18 13:54 -0500
      Re[2]: [newbie] advice and comment wanted on first tkinter program Grawburg <grawburg@myglnc.com> - 2014-01-18 13:49 -0500

csiph-web