Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > comp.lang.python > #50565

Re: Understanding other people's code

Path csiph.com!v102.xanadu-bbs.net!xanadu-bbs.net!goblin2!goblin.stu.neva.ru!newsfeed.xs4all.nl!newsfeed2.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
Return-Path <joel.goldstick@gmail.com>
X-Original-To python-list@python.org
Delivered-To python-list@mail.python.org
X-Spam-Status OK 0.013
X-Spam-Evidence '*H*': 0.97; '*S*': 0.00; 'output': 0.05; 'subject:code': 0.07; 'works.': 0.09; 'cc:addr:python-list': 0.11; 'python': 0.11; 'def': 0.12; 'jan': 0.12; 'docstrings': 0.16; 'email addr:udel.edu&gt;': 0.16; 'email name:&lt;tjreedy': 0.16; 'modules.': 0.16; 'reedy': 0.16; 'wrote:': 0.18; 'do.': 0.18; 'all,': 0.19; 'trying': 0.19; 'written': 0.21; 'cc:addr:python.org': 0.22; 'print': 0.22; 'documented': 0.24; 'together.': 0.24; "haven't": 0.24; 'cc:2**0': 0.24; "i've": 0.25; 'updating': 0.26; 'header:In-Reply-To:1': 0.27; 'am,': 0.29; 'message-id:@mail.gmail.com': 0.30; "i'm": 0.30; 'url:mailman': 0.30; 'asked': 0.31; 'code': 0.31; '(although': 0.31; 'documenting': 0.31; 'fixing': 0.31; 'subject:other': 0.31; 'this.': 0.32; 'extend': 0.32; 'figure': 0.32; 'url:python': 0.33; 'fri,': 0.33; 'classes': 0.35; 'test': 0.35; 'but': 0.35; 'received:google.com': 0.35; 'add': 0.35; 'there': 0.35; 'really': 0.36; 'url:listinfo': 0.36; 'url:org': 0.36; 'two': 0.37; 'project': 0.37; 'level': 0.37; 'pm,': 0.38; '12,': 0.39; 'url:mail': 0.40; 'even': 0.60; 'most': 0.60; 'details.': 0.61; 'real': 0.63; 'jul': 0.74; '6:11': 0.84; 'appreciative': 0.84; 'subject:people': 0.84; 'joel': 0.91; '2013': 0.98
DKIM-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=r0GoU9wgDcjCsr91+pz3b1MVJ9EuaYIusT25kOUSX3c=; b=sz1LCsEMZvQj7uj+fSPZyrgiLRZs1fsj+0/75zWUEZEroGKDqc+EEsRErD0c2GaJE4 KpfOc5xW2yf9rQ1e7eRiWl9hQaUBaANgxHaK+sPee+IKSw4Te2SgcgazF51iSVyOFBr4 rMv+Cit+N9S81YiXavNgynLUTQVib6e9dFYMJlmatBG93IOq/M1LqCu71Jgq9Hwnc8HB DRu+XLEjqPDoAFRjwKhJRZ7mhnyOhrZiWzHMEKsFj4TSrMJJiW0wzfkixZ5y/seRSuyS ZwaROpOLgZDPP2B7H76nFNKqXjYCCrFUeHnofIxTrTeju62HMpVDL+WCgoKCNfeZCbmy Cmew==
MIME-Version 1.0
X-Received by 10.220.164.138 with SMTP id e10mr25704836vcy.27.1373672971409; Fri, 12 Jul 2013 16:49:31 -0700 (PDT)
In-Reply-To <krpuv5$8cc$2@ger.gmane.org>
References <66c25416-eaa5-4ac1-a71d-2b2948dec2fb@googlegroups.com> <krpuv5$8cc$2@ger.gmane.org>
Date Fri, 12 Jul 2013 19:49:31 -0400
Subject Re: Understanding other people's code
From Joel Goldstick <joel.goldstick@gmail.com>
To Terry Reedy <tjreedy@udel.edu>
Content-Type multipart/alternative; boundary=001a11c1dfbc7fa0d904e159298c
Cc "python-list@python.org" <python-list@python.org>
X-BeenThere python-list@python.org
X-Mailman-Version 2.1.15
Precedence list
List-Id General discussion list for the Python programming language <python-list.python.org>
List-Unsubscribe <http://mail.python.org/mailman/options/python-list>, <mailto:python-list-request@python.org?subject=unsubscribe>
List-Archive <http://mail.python.org/pipermail/python-list/>
List-Post <mailto:python-list@python.org>
List-Help <mailto:python-list-request@python.org?subject=help>
List-Subscribe <http://mail.python.org/mailman/listinfo/python-list>, <mailto:python-list-request@python.org?subject=subscribe>
Newsgroups comp.lang.python
Message-ID <mailman.4668.1373672979.3114.python-list@python.org> (permalink)
Lines 92
NNTP-Posting-Host 2001:888:2000:d::a6
X-Trace 1373672979 news.xs4all.nl 15870 [2001:888:2000:d::a6]:54140
X-Complaints-To abuse@xs4all.nl
Xref csiph.com comp.lang.python:50565

Show key headers only | View raw


[Multipart message — attachments visible in raw view] - view raw

On Fri, Jul 12, 2013 at 6:11 PM, Terry Reedy <tjreedy@udel.edu> wrote:

> On 7/12/2013 10:22 AM, L O'Shea wrote:
>
>> Hi all, I've been asked to take over a project from someone else and
>> to extend the functionality of this. The project is written in Python
>> which I haven't had any real experience with (although I do really
>> like it) so I've spent the last week or two settling in, trying to
>> get my head around Python and the way in which this code works.
>>
>
> If the functions are not documented in prose, is there a test suite that
> you can dive into?
>
>
> --
> Terry Jan Reedy
>
> --
> http://mail.python.org/**mailman/listinfo/python-list<http://mail.python.org/mailman/listinfo/python-list>
>

I'm very appreciative of pydoc. -- even for code I write myself!.  Learn
about it and redirect its output to files, so you can print out all of your
modules.  (well -- my suggestion!).  For the functions and classes that are
lacking docstrings, review them and see if you can figure out what they
do.  Add docstrings..

Not to disrespect this original coder in the slightest, but my work
experience has been involved in reading and fixing or updating lots of
other peoples code -- most less documented than would be nice.  So my def
of good code is code with good descriptive docstrings -- at the top level
even before documenting the details.  Its nice to know where the
developer's head was at when the system was put together.

-- 
Joel Goldstick
http://joelgoldstick.com

Back to comp.lang.python | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Understanding other people's code "L O'Shea" <lo0446@my.bristol.ac.uk> - 2013-07-12 07:22 -0700
  Re: Understanding other people's code Chris Angelico <rosuav@gmail.com> - 2013-07-13 00:46 +1000
  Re: Understanding other people's code Peter Otten <__peter__@web.de> - 2013-07-12 17:21 +0200
  Re: Understanding other people's code "Eric S. Johansson" <esj@harvee.org> - 2013-07-12 12:04 -0400
  Re: Understanding other people's code Terry Reedy <tjreedy@udel.edu> - 2013-07-12 18:11 -0400
  Re: Understanding other people's code Joel Goldstick <joel.goldstick@gmail.com> - 2013-07-12 19:49 -0400
  Re: Understanding other people's code CM <cmpython@gmail.com> - 2013-07-13 23:58 -0700
  Re: Understanding other people's code Azureaus <lo0446@my.bristol.ac.uk> - 2013-07-15 03:02 -0700
    Re: Understanding other people's code CM <cmpython@gmail.com> - 2013-07-15 12:13 -0700
    Re: Understanding other people's code albert@spenarnc.xs4all.nl (Albert van der Horst) - 2013-07-27 13:13 +0000
      Re: Understanding other people's code Chris Angelico <rosuav@gmail.com> - 2013-07-27 14:41 +0100
  Re: Understanding other people's code asimjalis@gmail.com - 2013-07-15 19:10 -0700
  Re: Understanding other people's code David M Chess <chess@us.ibm.com> - 2013-07-16 14:38 -0400
  Re: Understanding other people's code David Hutto <dwightdhutto@gmail.com> - 2013-07-16 20:05 -0400
  Re: Understanding other people's code David Hutto <dwightdhutto@gmail.com> - 2013-07-19 22:57 -0400
  Re: Understanding other people's code Azureaus <lo0446@my.bristol.ac.uk> - 2013-07-25 09:26 -0700

csiph-web