Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > comp.lang.python > #97327

Re: Only getting the first 6 lines

From Peter Otten <__peter__@web.de>
Subject Re: Only getting the first 6 lines
Date 2015-10-02 09:37 +0200
Organization None
References <87y4fmp7xi.fsf@Equus.decebal.nl>
Newsgroups comp.lang.python
Message-ID <mailman.328.1443771487.28679.python-list@python.org> (permalink)

Show all headers | View raw


Cecil Westerhof wrote:

> I want to get the first 6 lines of ps output. For this I use:
> ========================================================================
> from subprocess import check_output
> 
> ps_command = ('ps', '-eo', 'user,pid,pcpu,pmem,stat,start,time,cmd',
> '--sort') message = '\n'.join(check_output(ps_command +
> ('-%cpu',)).decode("utf-8").splitlines()[0:6])
> ========================================================================
> 
> It works, but does not look very efficient. Is there a better way to
> do this?

Efficiency be damned, readability counts ;)

With that in mind here's a little code cleanup:

 
import subprocess

def text_head(text, n):
    return "\n".join(text.split("\n", n)[:n])

def ps(sort=None):
    cmd = ['ps', '-eo', 'user,pid,pcpu,pmem,stat,start,time,cmd']
    if sort is not None:
        cmd += ["--sort", sort]
    return subprocess.check_output(cmd, universal_newlines=True)

if __name__ == "__main__":
    print(text_head(ps("-%cpu"), 6))

For long strings and small n text.split(\n", n)[:n] is a bit faster than 
text.splitlines()[n]

$ wc -l fodder.txt
969 fodder.txt
$ python3 -m timeit -s 'text = open("fodder.txt").read()' 'text.split("\n", 
6)[:6]'
100000 loops, best of 3: 7.54 usec per loop
$ python3 -m timeit -s 'text = open("fodder.txt").read()' 'text.splitlines()
[:6]'
1000 loops, best of 3: 215 usec per loop

but the effect on the total time to run the code should be negligable.

Back to comp.lang.python | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Only getting the first 6 lines Cecil Westerhof <Cecil@decebal.nl> - 2015-10-01 23:58 +0200
  Re: Only getting the first 6 lines Ian Kelly <ian.g.kelly@gmail.com> - 2015-10-01 16:58 -0600
  Re: Only getting the first 6 lines Cameron Simpson <cs@zip.com.au> - 2015-10-02 08:50 +1000
    Re: Only getting the first 6 lines Cecil Westerhof <Cecil@decebal.nl> - 2015-10-02 13:08 +0200
  Re: Only getting the first 6 lines Peter Otten <__peter__@web.de> - 2015-10-02 09:37 +0200
    Re: Only getting the first 6 lines Cecil Westerhof <Cecil@decebal.nl> - 2015-10-02 13:11 +0200

csiph-web