Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.python > #56615

Re: class implementation

Show all headers | View raw

markotaht@gmail.com writes:

>
> OK so I did a took time of and read the pykkar code through. abd I found that there is a third class i have to implement. 

[...]

> So I have come up with this code
> from pykkar import *
>
> create_world("""
> ########
> #      #
> #     v#
> #      #
> #      #
> #      #
> ########
> """)
>
> class world_täiend(World):
>     def left(self):
>         world.excecute("left")
>         
> class pykkar_täiend(Pykkar):
>     def left(self):
>         self._world.excecute("left")
>
> class _WorldProper_täiend(_WorldProper):
>     def _cmd_right(self):

Should that not be _cmd_left?

>         headings = (N,E,S,W)
>         cur_tile = self._get_current_tile() 
>         
>         cur_heading_index = headings.index(cur_tile.pykkar_heading)
>         new_heading_index = (cur_heading_index - 1) % 4
>         cur_tile.pykkar_heading = headings[new_heading_index]
>         
>         self._update_pykkar_image(cur_tile)
>
>
> left()
>
> When I run my code I get this error.
> Traceback (most recent call last):
>   File "C:\Users\MarkoPC\Desktop\python\pykkar_test.py", line 21, in <module>
>     class _WorldProper_täiend(_WorldProper):
> NameError: name '_WorldProper' is not defined

from import * doesn't import names that start with underscore (_). So therefore _WorldProper is not defined.

from import * is considered bad practice anyway. It is better just to import the things you need.

from pykkar import World, Pykkar, _WorldProper

I have looked a bit in this pykkar.py and I think it is badly structured for extension. The three classes are too strongly connected and it is difficult to get three subclasses connected in the proper way without duplicating code. But anyway you will have to do that when you create your world.

-- 
Piet van Oostrum <piet@vanoostrum.org>
WWW: http://pietvanoostrum.com/
PGP key: [8DAE142BE17999C4]

Back to comp.lang.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

class implementation markotaht@gmail.com - 2013-09-30 01:43 -0700
  Re: class implementation Peter Otten <__peter__@web.de> - 2013-09-30 11:03 +0200
  Re: class implementation markotaht@gmail.com - 2013-09-30 02:10 -0700
    Re: class implementation Peter Otten <__peter__@web.de> - 2013-09-30 11:27 +0200
  Re: class implementation markotaht@gmail.com - 2013-09-30 05:41 -0700
    Re: class implementation Peter Otten <__peter__@web.de> - 2013-09-30 15:02 +0200
    Re: class implementation Joel Goldstick <joel.goldstick@gmail.com> - 2013-09-30 09:21 -0400
    Re: class implementation Piet van Oostrum <piet@vanoostrum.org> - 2013-09-30 13:32 -0400
    Re: class implementation Dave Angel <davea@davea.name> - 2013-09-30 19:34 +0000
      Re: class implementation 88888 Dihedral <dihedral88888@gmail.com> - 2013-10-01 00:01 -0700
    Re: class implementation Ned Batchelder <ned@nedbatchelder.com> - 2013-09-30 17:28 -0400
      Re: class implementation Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2013-09-30 23:45 +0000
        Re: class implementation Ethan Furman <ethan@stoneleaf.us> - 2013-09-30 17:31 -0700
    Re: class implementation random832@fastmail.us - 2013-09-30 17:49 -0400
    Python variables?  [was Re: class implementation] Ethan Furman <ethan@stoneleaf.us> - 2013-09-30 15:02 -0700
    Re: Python variables? Ben Finney <ben+python@benfinney.id.au> - 2013-10-01 08:37 +1000
    Re: Python variables?  [was Re: class implementation] Ned Batchelder <ned@nedbatchelder.com> - 2013-09-30 19:45 -0400
      Re: Python variables?  [was Re: class implementation] "Rhodri James" <rhodri@wildebst.demon.co.uk> - 2013-10-01 01:29 +0100
    Re: Python variables? Ned Batchelder <ned@nedbatchelder.com> - 2013-09-30 19:47 -0400
      Re: Python variables? Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2013-10-01 01:03 +0000
        Re: Python variables? Ned Batchelder <ned@nedbatchelder.com> - 2013-09-30 21:28 -0400
    Re: class implementation Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2013-10-01 00:19 +0000
  Re: class implementation markotaht@gmail.com - 2013-10-06 06:15 -0700
    Re: class implementation Terry Reedy <tjreedy@udel.edu> - 2013-10-06 15:52 -0400
    Re: class implementation Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2013-10-07 01:24 +0000
  Re: class implementation markotaht@gmail.com - 2013-10-08 01:20 -0700
    Re: class implementation Mark Lawrence <breamoreboy@yahoo.co.uk> - 2013-10-08 09:41 +0100
    Re: class implementation Dave Angel <davea@davea.name> - 2013-10-08 10:31 +0000
    Re: class implementation Cameron Simpson <cs@zip.com.au> - 2013-10-09 10:55 +1100
      Re: class implementation markotaht@gmail.com - 2013-10-10 11:34 -0700
        Re: class implementation Cameron Simpson <cs@zip.com.au> - 2013-10-11 09:07 +1100
        Re: class implementation Piet van Oostrum <piet@vanoostrum.org> - 2013-10-10 19:29 -0400
          Re: class implementation Ben Finney <ben+python@benfinney.id.au> - 2013-10-11 10:51 +1100
  Re: class implementation markotaht@gmail.com - 2013-10-08 07:05 -0700
    Re: class implementation "Rhodri James" <rhodri@wildebst.demon.co.uk> - 2013-10-09 00:41 +0100

csiph-web