Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.python > #74254

Help me write better Code

Show all headers | View raw

Hello,

I have working code - but looking for better/improved code. Better coding practices, better algorithm :) 

Problem: Given sequence of increasing integers, print blocks of consecutive integers. 

Example: 

Input: [10, 11, 12, 15]
Output: [10, 11, 12]

Input: [51, 53, 55, 67, 68, 91, 92, 93, 94, 99]
Outout: [67, 68], [91, 92, 93, 94]
 
My code looks as below: 
-----------------------------
#!/usr/bin/python
a = [51, 53, 55, 67, 68, 91, 92, 93, 94, 99]
#a = []
#a = [10]
#a = [10, 11, 12, 15]
print "Input: "
print  a

prev = 0
blocks = []
tmp = []
last = 0
for element in a:
   if prev == 0:
      prev = element
      next
   if element == prev + 1:
       if tmp:
           pass
       else:
           tmp.append(prev)
       tmp.append(element)
   else:
       if tmp:
          blocks.append(tmp)
       tmp = []

   prev = element

if tmp:
    blocks.append(tmp)

if blocks:
    #print "I have repeated elements and those are:"
    for b in blocks:
        print b

-----------------------

thank you in advance!

Back to comp.lang.python | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Help me write better Code sssdevelop <sssdevelop@gmail.com> - 2014-07-09 07:27 -0700
  Re: Help me write better Code Mark Lawrence <breamoreboy@yahoo.co.uk> - 2014-07-09 16:44 +0100
    Re: Help me write better Code sssdevelop <sssdevelop@gmail.com> - 2014-07-10 07:39 -0700
      Re: Help me write better Code Mark Lawrence <breamoreboy@yahoo.co.uk> - 2014-07-10 15:51 +0100
    Re: Help me write better Code Rustom Mody <rustompmody@gmail.com> - 2014-07-10 11:38 -0700
  Re: Help me write better Code Ian Kelly <ian.g.kelly@gmail.com> - 2014-07-09 12:16 -0600
    Re: Help me write better Code sssdevelop <sssdevelop@gmail.com> - 2014-07-10 07:38 -0700
  Re: Help me write better Code Terry Reedy <tjreedy@udel.edu> - 2014-07-09 14:46 -0400
    Re: Help me write better Code sssdevelop <sssdevelop@gmail.com> - 2014-07-10 07:38 -0700

csiph-web