Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.javascript > #7424

Re: String Replace. Please, need help.

Show all headers | View raw

Luuk wrote on 15 okt 2011 in comp.lang.javascript:

> On 15-10-2011 12:04, Evertjan. wrote:
>> Luuk wrote on 15 okt 2011 in comp.lang.javascript:
>>
>>> On 15-10-2011 11:32, Evertjan. wrote:
>>>>>           X = source.replace("{id}", options.id)
>>>>>>            content = X.replace("{title}", title)
>>>>>>   and then you can test that in each case a change has been made, 
by
>>>>>>   comparing the strings with == or != .
>>>> Yes, but that would not solve this:
>>>>
>>>>>>>>   However "source" might have or not have
>>>>>>>>   the strings "{id}" and "{title}".
>>>>>>>>   When it does not have I get an error.
>>>
>>> function myReplace(s, t, u) {
>>>       if s.indexOf(t)>=0 {
>>>            return s.replace(t,u);
>>>      } else {
>>>            return s;
>>>      }
>>> }
>>>
>>> X = myReplace(source,"{id}", options.id);
>>> content = myReplace (X, "{title}", title);
>>
>> Please explain your improvement, Luuk.
>>
>> I don't get an error here:
>>
>> ========================
>> var s = 'xxxx';
>> var t = '{id}';
>>
>> alert(s.indexOf(t)); // -1
>>
>> var r = s.replace(t, 'blah');
>>
>> alert(r); // xxx
>> ========================
> 
> The OP said:
> However "source" might have or not have the strings "{id}" and 
> "{title}". When it does not have I get an error.
> 
> So, adding a test if it does can help.
> 
> But when the 'normal'  replace does not give an error, it still is very 
> hard to find out why the OP gets en error in that case.....

I do not think your approach will help, Luuk,
as the the OP must be in error if he ment that the replace() ever would 
give such an error.

I showed that if your s.indexOf(t) returns -1 the replace() still allows 
this withourt throwing an error.

So the OP should set temporary breakpoints, like alert(1), alert(2), etc,
and replace the source string with known temporary strings having and 
then not having the substring to be replaced, to determine where the 
error occurs.

That is the good old-fashioned way of debugging.

-- 
Evertjan.
The Netherlands.
(Please change the x'es to dots in my emailaddress)

Back to comp.lang.javascript | Previous | Next — Previous in thread | Next in thread | Find similar

Thread

String Replace. Please, need help. "Shapper." <mdmoura@gmail.com> - 2011-10-13 12:42 -0700
  Re: String Replace. Please, need help. "Evertjan." <exjxw.hannivoort@interxnl.net> - 2011-10-13 21:17 +0000
  Re: String Replace. Please, need help. "Tom de Neef" <tdeneef@qolor.nl> - 2011-10-14 09:43 +0200
    Re: String Replace. Please, need help. Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2011-10-14 21:01 +0200
  Re: String Replace. Please, need help. Dr J R Stockton <reply1141@merlyn.demon.co.uk> - 2011-10-14 21:02 +0100
    Re: String Replace. Please, need help. "Evertjan." <exjxw.hannivoort@interxnl.net> - 2011-10-15 09:32 +0000
      Re: String Replace. Please, need help. Luuk <Luuk@invalid.lan> - 2011-10-15 11:47 +0200
        Re: String Replace. Please, need help. "Evertjan." <exjxw.hannivoort@interxnl.net> - 2011-10-15 10:04 +0000
          Re: String Replace. Please, need help. Luuk <Luuk@invalid.lan> - 2011-10-15 12:14 +0200
            Re: String Replace. Please, need help. "Evertjan." <exjxw.hannivoort@interxnl.net> - 2011-10-15 12:21 +0000
              Re: String Replace. Please, need help. Andreas Bergmaier <andber93@web.de> - 2011-10-15 22:49 +0200
                Re: String Replace. Please, need help. Antony Scriven <adscriven@gmail.com> - 2011-10-15 15:37 -0700
                Re: String Replace. Please, need help. Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2011-10-16 01:08 +0200
      Re: String Replace. Please, need help. Dr J R Stockton <reply1141@merlyn.demon.co.uk> - 2011-10-16 19:30 +0100
  Re: String Replace. Please, need help. Bart Lateur <bart.lateur@telenet.be> - 2011-10-18 19:49 +0200

csiph-web