Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.javascript > #8605

Re: Read url into a string?

Followups directed to: comp.lang.javascript

Show all headers | View raw

Zlatko Đurić wrote:

> function getJSONfromUrl(url) {
>    if (window.XMLHttpRequest) {
>      xhr=new XMLHttpRequest();
>    } else {
>      xhr=new ActiveXObject("Microsoft.XMLHTTP");
>    }
>    xhr.open("GET",url,false);
>    xhr.send();
>    return xhr.responseText;
> }
> 
> ?

The flaws of this code are many:

- Bogus XHR() feature test
- `xhr' not declared a variable
- Missing XHR() exception handling
- Missing ActiveXObject feature test
- Missing XMLHTTP selection
- Missing ActiveXObject() exception handling
- Missing non-XHR()-non-MSXML branch
- Unnecessary synchronous request blocking the client window/tab
- Missing send() argument
- Missing status check
- Insufficient code style

So it is neither safe nor compatible or user-friendly, but it might suffice 
for a first dry run.  `url' cannot be any URI though, as the Same Origin 
Policy would prevent cross-protocol/domain/port access unless the owner of 
the other site explicitly allowed it.

<https://developer.mozilla.org/En/HTTP_access_control>


PointedEars
-- 
var bugRiddenCrashPronePieceOfJunk = (
    navigator.userAgent.indexOf('MSIE 5') != -1
    && navigator.userAgent.indexOf('Mac') != -1
)  // Plone, register_function.js:16

Back to comp.lang.javascript | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Read url into a string? SpreadTooThin <bjobrien62@gmail.com> - 2011-11-23 14:09 -0800
  Re: Read url into a string? Gene Wirchenko <genew@ocis.net> - 2011-11-23 15:00 -0800
    Re: Read url into a string? SpreadTooThin <bjobrien62@gmail.com> - 2011-11-23 15:28 -0800
    Re: Read url into a string? Zlatko Đurić <zladuric@gmail.com> - 2011-11-24 00:29 +0100
      Re: Read url into a string? SpreadTooThin <bjobrien62@gmail.com> - 2011-11-23 15:34 -0800
      Re: Read url into a string? SpreadTooThin <bjobrien62@gmail.com> - 2011-11-23 15:37 -0800
      Re: Read url into a string? SpreadTooThin <bjobrien62@gmail.com> - 2011-11-23 16:35 -0800
        Re: Read url into a string? Scott Sauyet <scott.sauyet@gmail.com> - 2011-11-23 18:02 -0800
      Re: Read url into a string? Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2011-11-24 21:27 +0100
        Re: Read url into a string? Zlatko Đurić <zladuric@gmail.com> - 2011-11-24 22:13 +0100
          Re: Read url into a string? Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2011-11-24 22:31 +0100
            Re: Read url into a string? Zlatko Đurić <zladuric@gmail.com> - 2011-11-24 23:08 +0100
      Re: Read url into a string? Arno Welzel <usenet@arnowelzel.de> - 2011-11-25 15:59 +0100
  Re: Read url into a string? "Evertjan." <test@abc.invalid> - 2011-11-26 13:44 -0400

csiph-web