Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.javascript > #7398

Re: FAQ Topic - How do I trim whitespace? (2011-10-14)

Followups directed to: comp.lang.javascript

Show all headers | View raw

J.R. wrote:

> FAQ server wrote:
>> -----------------------------------------------------------------------
>> FAQ Topic - How do I trim whitespace?
>> -----------------------------------------------------------------------
>>
>> ECMAScript 5 defines `String.prototype.trim`. Where not supported,
>> it can be added as a function that uses a regular expression:
>>
>> if(!String.prototype.trim) {
>> String.prototype.trim = function() {
>> return String(this).replace(/^\s+|\s+$/g, "");
>> };
>> }
> 
>> The complete comp.lang.javascript FAQ is at
>> http://jibbering.com/faq/
>>
> 
> A few months ago, there was an article at Jibbering,com with a different
> version of this code:
> 
>    /** @see http://jibbering.com/faq/#trimString */
>    if (typeof String.prototype.trim !== "function") {
>      String.prototype.trim = function () {
>        // return String(this).replace(/^\s+|\s+$/g, "");
>        return this.replace(/^\s+|\s+$/g, "");
>      };
>    }
> 
> I think that is more consistent with ECMA-262 5th ed., 15.5.4.20.

`!x' requires

  RETURN Not(ToBoolean(GetValue(x)));

`typeof x !== y' requires
 
  lref := FUNCTION(x) {
    val := GetValue(x);
    IF Type(val) = Reference
    {
      IF IsUnresolvableReference(v)
      {
        RETURN "undefined";
      }
      val := GetValue(val);
    }
    RETURN GetResultByType(Type(val));
  }(x);
  lval := GetValue(lref);
  rref := Evaluate(y);
  rval := GetValue(rref);
  r := (rval === lval);  /* 11.9.6 */
  RETURN Not(r);

Implicit type conversion may suffice, especially iff it is more efficient 
than `typeof' (benchmarks anyone?); it is not logical to assume that the 
property would be assigned a non-function true-value, or a host object 
reference.

Regardless, strict comparison is pointless here.  `typeof' is not going to 
result in a non-string.

Also, we are at ES 5.1 (2011-06) by now, and section 15.5.4.20 says 
basically what the line does that is commented out here (there are 
implementations that do not implement whitespace as specified in ECMAScript, 
but it appears prudent that whitespace be handled either implementation-
independent or implementation-dependent in all places in a script library).


PointedEars
-- 
Use any version of Microsoft Frontpage to create your site.
(This won't prevent people from viewing your source, but no one
will want to steal it.)
  -- from <http://www.vortex-webdesign.com/help/hidesource.htm> (404-comp.)

Back to comp.lang.javascript | Previous | Next — Previous in thread | Next in thread | Find similar

Thread

FAQ Topic - How do I trim whitespace? (2011-10-14) "FAQ server" <javascript@dotinternet.be> - 2011-10-13 23:00 +0000
  Re: FAQ Topic - How do I trim whitespace? (2011-10-14) "J.R." <groups_jr-1@yahoo.com.br> - 2011-10-13 22:09 -0300
    Re: FAQ Topic - How do I trim whitespace? (2011-10-14) Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2011-10-14 20:54 +0200
    Re: FAQ Topic - How do I trim whitespace? (2011-10-14) Dr J R Stockton <reply1141@merlyn.demon.co.uk> - 2011-10-15 19:17 +0100

csiph-web