Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > comp.lang.java.programmer > #38926
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!reader01.eternal-september.org!.POSTED!not-for-mail |
|---|---|
| From | Daniele Futtorovic <da.futt.news@laposte-dot-net.invalid> |
| Newsgroups | comp.lang.java.programmer |
| Subject | Re: Java variable access |
| Date | Wed, 17 Apr 2019 21:35:43 +0200 |
| Organization | A noiseless patient Spider |
| Lines | 22 |
| Message-ID | <q97v7m$mr6$1@dont-email.me> (permalink) |
| References | <109a7224-f392-46c3-bf56-7d8bf2bfb4bf@googlegroups.com> <13t97bxk9km7n$.ooqi8n8ocm7f$.dlg@40tude.net> <q8rfas$iti$1@gioia.aioe.org> <13ak6boysjgrh$.1h4x7tkjgs00q$.dlg@40tude.net> <q8tod9$kb9$1@gioia.aioe.org> <7ivllvz2ukra$.qlcrlm81adao.dlg@40tude.net> <q95ev0$3s8$1@dont-email.me> <28f31a7a-5bdf-4eaa-ad70-df6c0751b5ff@googlegroups.com> |
| Mime-Version | 1.0 |
| Content-Type | text/plain; charset=utf-8 |
| Content-Transfer-Encoding | 7bit |
| Injection-Date | Wed, 17 Apr 2019 19:36:22 -0000 (UTC) |
| Injection-Info | reader02.eternal-september.org; posting-host="e41d12507d7438a4aed6faf6b13a8e45"; logging-data="23398"; mail-complaints-to="abuse@eternal-september.org"; posting-account="U2FsdGVkX1+NMJ1xa/BoxOn65cMXPKls" |
| User-Agent | Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
| Cancel-Lock | sha1:hgME4XLNaa5mdmpXyK7kckmHiyg= |
| In-Reply-To | <28f31a7a-5bdf-4eaa-ad70-df6c0751b5ff@googlegroups.com> |
| X-Antivirus-Status | Clean |
| Content-Language | en-US |
| X-Antivirus | AVG (VPS 190417-4, 04/17/2019), Outbound message |
| Xref | csiph.com comp.lang.java.programmer:38926 |
Show key headers only | View raw
On 2019-04-17 15:42, Eric Douglas wrote:
> On Tuesday, April 16, 2019 at 4:46:33 PM UTC-4, Eric Sosman wrote:
>> What is wrong (tm) with
>>
>> public void setUnitPrice(double unitPrice) {
>> if (unitPrice <= 0 || !Double.isFinite(unitPrice)) {
>> throw new IllegalArgumentException(
>> "bad price: " + unitPrice);
>> }
>> if (unitPrice != this.unitPrice) {
>> this.unitPrice = unitPrice;
>> fireChangeEvent(this, PRICE_CHANGED);
>> }
>> }
>>
>
> If you leave off the validation and just declare class variable public double unitPrice, you either validate it where it gets used or never validate assuming it's ok to just throw an error where it would be used if it somehow gets an invalid value.
That has to be the worst advice I've read in quite a while.
--
DF.
Back to comp.lang.java.programmer | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Java variable access Eric Douglas <e.d.programmer@gmail.com> - 2019-04-12 06:57 -0700
Re: Java variable access Arne Vajhøj <arne@vajhoej.dk> - 2019-04-12 10:06 -0400
Re: Java variable access Eric Douglas <e.d.programmer@gmail.com> - 2019-04-12 07:23 -0700
Re: Java variable access Arne Vajhøj <arne@vajhoej.dk> - 2019-04-12 10:35 -0400
Re: Java variable access Eric Sosman <esosman@comcast-dot-net.invalid> - 2019-04-12 10:58 -0400
Re: Java variable access Eric Douglas <e.d.programmer@gmail.com> - 2019-04-12 08:31 -0700
Re: Java variable access Eric Sosman <esosman@comcast-dot-net.invalid> - 2019-04-12 14:40 -0400
Re: Java variable access Arne Vajhøj <arne@vajhoej.dk> - 2019-04-12 12:31 -0400
Re: Java variable access Eric Sosman <esosman@comcast-dot-net.invalid> - 2019-04-12 10:56 -0400
Re: Java variable access Joerg Meier <joergmmeier@arcor.de> - 2019-04-12 23:11 +0200
Re: Java variable access Arne Vajhøj <arne@vajhoej.dk> - 2019-04-12 21:51 -0400
Re: Java variable access Joerg Meier <joergmmeier@arcor.de> - 2019-04-13 21:59 +0200
Re: Java variable access Arne Vajhøj <arne@vajhoej.dk> - 2019-04-13 18:38 -0400
Re: Java variable access Joerg Meier <joergmmeier@arcor.de> - 2019-04-16 22:08 +0200
Re: Java variable access Eric Sosman <esosman@comcast-dot-net.invalid> - 2019-04-16 16:46 -0400
Re: Java variable access Joerg Meier <joergmmeier@arcor.de> - 2019-04-16 23:01 +0200
Re: Java variable access Eric Douglas <e.d.programmer@gmail.com> - 2019-04-17 06:42 -0700
Re: Java variable access Daniele Futtorovic <da.futt.news@laposte-dot-net.invalid> - 2019-04-17 21:35 +0200
Re: Java variable access Eric Douglas <e.d.programmer@gmail.com> - 2019-04-17 14:05 -0700
Re: Java variable access Joerg Meier <joergmmeier@arcor.de> - 2019-04-19 10:40 +0200
Re: Java variable access Eric Sosman <esosman@comcast-dot-net.invalid> - 2019-04-19 17:20 -0400
csiph-web