Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.java.programmer > #11133

Re: Regex doesn't recognize single quote

Show all headers | View raw

Wow, that is some of the worst String manipulation code I've seen.

On 1/7/12 3:36 PM, Stefan Ram wrote:
>    static String scrunch( final String s )
>    { final java.lang.String string = s.toString();
s.toString() == s for all non-null instances of String. Unneeded.

>      final java.lang.String result = s.replaceAll( "('|\\\\w)", "" );
You don't need an intermediate here.

>      return new String( result ); }
Strings are (mostly) immutable. There are extremely few good reasons to 
invoke the String(String) constructor manually.  Not to mention 
s.replaceAll() will already potentially return a new String.
>
>    (Assuming the class »String« has an appropriate constructor.)
It does, but why use it unless you want to guaranty that they are 
.equals, but !=.



I'm not even going to comment on your insane style, as I think you've 
rebuffed all comments in the past.  What I will comment on is the lack 
of consistency in this snippet. Some places use use "String" and others 
"java.lang.String".


>    (This implements your documentation, not what the OP wanted.)
So does this, but with less waste and confusion.
static String scrunch( final String source) {
    return s.replaceAll( "('|\\\\w)", "" );
}

Back to comp.lang.java.programmer | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Regex doesn't recognize single quote Jerric <jerricgao@gmail.com> - 2012-01-06 14:08 -0800
  Re: Regex doesn't recognize single quote Martin Gregorie <martin@address-in-sig.invalid> - 2012-01-06 22:23 +0000
  Re: Regex doesn't recognize single quote Jake Jarvis <pig_in_shoes@yahoo.com> - 2012-01-06 23:48 +0100
  Re: Regex doesn't recognize single quote Daniel Pitts <newsgroup.nospam@virtualinfinity.net> - 2012-01-06 15:49 -0800
    Re: Regex doesn't recognize single quote Jim Janney <jjanney@shell.xmission.com> - 2012-01-07 19:02 -0700
      Re: Regex doesn't recognize single quote Daniel Pitts <newsgroup.nospam@virtualinfinity.net> - 2012-01-09 09:58 -0800
  Re: Regex doesn't recognize single quote Roedy Green <see_website@mindprod.com.invalid> - 2012-01-06 21:47 -0800
    Re: Regex doesn't recognize single quote Roedy Green <see_website@mindprod.com.invalid> - 2012-01-07 14:41 -0800
      Re: Regex doesn't recognize single quote Rafael Villar <morgano5@hotmail.com> - 2012-01-08 09:05 +1000
        Re: Regex doesn't recognize single quote Rafael Villar <morgano5@hotmail.com> - 2012-01-08 09:10 +1000
        Re: Regex doesn't recognize single quote Lew <noone@lewscanon.com> - 2012-01-07 17:20 -0800
      Re: Regex doesn't recognize single quote Daniel Pitts <newsgroup.nospam@virtualinfinity.net> - 2012-01-09 10:08 -0800
        Re: Regex doesn't recognize single quote Daniel Pitts <newsgroup.nospam@virtualinfinity.net> - 2012-01-09 10:33 -0800
    Re: Regex doesn't recognize single quote Roedy Green <see_website@mindprod.com.invalid> - 2012-01-07 14:48 -0800
      Re: Regex doesn't recognize single quote Arved Sandstrom <asandstrom3minus1@eastlink.ca> - 2012-01-07 20:58 -0400

csiph-web