Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.java.programmer > #20232

Re: Java (android) socket reconnection

Show all headers | View raw

artik wrote:
>> try {
>>     sock = new Socket();
>>     sock.connect(new InetSocketAddress(address, 5000), 1000);
>>     out = new BufferedWriter( new OutputStreamWriter(sock.getOutputStream()));
> > } catch (IOException e1) {
>>     if( sock != null ){

Umm, no. This part belongs in a 'finally' block, not a 'catch' block. Oops.

>>         try { sock.close(); } catch( IOException ioex ){
>> ioex.printStacktrace(); }

You need to format your code better. This is virtually unreadable.

>>         sock = null;

With a 'final sock' variable and multiple try-catch blocks you can avoid the check for 'null' 
and the reset to 'null'. (You probably don't need the reset now anyway.)
  
>>     }
>> }
> 
> I don't know why yesterday - No, but today Yes - it works perfect for me.

I doubt that very much. As written it is buggy.

-- 
Lew

Back to comp.lang.java.programmer | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Java (android) socket reconnection artik <olsztyn.arti@gmail.com> - 2012-12-09 07:06 -0800
  Re: Java (android) socket reconnection Daniele Futtorovic <da.futt.news@laposte-dot-net.invalid> - 2012-12-09 16:55 +0100
    Re: Java (android) socket reconnection artik <olsztyn.arti@gmail.com> - 2012-12-09 08:26 -0800
      Re: Java (android) socket reconnection Daniele Futtorovic <da.futt.news@laposte-dot-net.invalid> - 2012-12-09 19:07 +0100
        Re: Java (android) socket reconnection artik <olsztyn.arti@gmail.com> - 2012-12-09 12:36 -0800
          Re: Java (android) socket reconnection Daniele Futtorovic <da.futt.news@laposte-dot-net.invalid> - 2012-12-09 23:07 +0100
            Re: Java (android) socket reconnection artik <olsztyn.arti@gmail.com> - 2012-12-09 14:45 -0800
              Re: Java (android) socket reconnection Daniele Futtorovic <da.futt.news@laposte-dot-net.invalid> - 2012-12-10 00:47 +0100
            Re: Java (android) socket reconnection artik <olsztyn.arti@gmail.com> - 2012-12-10 13:09 -0800
              Re: Java (android) socket reconnection Lew <lewbloch@gmail.com> - 2012-12-10 13:52 -0800
    Re: Java (android) socket reconnection artik <olsztyn.arti@gmail.com> - 2012-12-09 08:34 -0800
  Re: Java (android) socket reconnection Eric Sosman <esosman@comcast-dot-net.invalid> - 2012-12-09 11:09 -0500
    Re: Java (android) socket reconnection artik <olsztyn.arti@gmail.com> - 2012-12-09 08:33 -0800

csiph-web