Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.java.help > #738

Re: TeeOutputStream?

Show all headers | View raw

Sat, 04 Jun 2011 17:17:04 -0700, /Knute Johnson/:

> public void close() throws IOException {
>      try {
>          os1.close();
>      } finally {
>          os2.close();
>      }
> }
>
> This guarantees that both close() methods will get called.  If both
> methods throw IOExceptions the caller will never see the first one as it
> will be hidden.

I usually do:

     boolean success = false;
     try {
         os1.close();
         success = true;
     } finally {
         try {
             os2.close();
         } catch (IOException ex) {
             if (success) {
                 throw ex;
             }
             // Log 'ex' possibly as warning to look at
             // subsequent error logs for details (about
             // the "original" exception).
         }
     }

Yes it looks messy.  Java 7 promises to bring improvement in that 
area with try-with-resources (auto-closeable resources) and 
exception masking:

http://www.oracle.com/technetwork/articles/java/trywithresources-401775.html

-- 
Stanimir

Back to comp.lang.java.help | Previous | Next — Previous in thread | Next in thread | Find similar

Thread

TeeOutputStream? Knute Johnson <nospam@knutejohnson.com> - 2011-06-04 17:17 -0700
  Re: TeeOutputStream? Roedy Green <see_website@mindprod.com.invalid> - 2011-06-04 22:18 -0700
  Re: TeeOutputStream? Stanimir Stamenkov <s7an10@netscape.net> - 2011-06-05 10:44 +0300
  Re: TeeOutputStream? rossum <rossum48@coldmail.com> - 2011-06-05 12:23 +0100
    Re: TeeOutputStream? Stanimir Stamenkov <s7an10@netscape.net> - 2011-06-06 01:23 +0300
      Re: TeeOutputStream? Patricia Shanahan <pats@acm.org> - 2011-06-05 16:55 -0700
        Re: TeeOutputStream? Stanimir Stamenkov <s7an10@netscape.net> - 2011-06-07 00:45 +0300
      Re: TeeOutputStream? rossum <rossum48@coldmail.com> - 2011-06-06 15:16 +0100
  Re: TeeOutputStream? markspace <-@.> - 2011-06-06 14:08 -0700
  Re: TeeOutputStream? Henk van Voorthuijsen <voorth@gmail.com> - 2011-06-08 03:31 -0700
    Re: TeeOutputStream? Knute Johnson <nospam@knutejohnson.com> - 2011-06-08 16:11 -0700

csiph-web