Path: csiph.com!weretis.net!feeder8.news.weretis.net!news.szaf.org!news.karotte.org!news.space.net!news.muc.de!.POSTED.news.muc.de!not-for-mail
From: Martin Husemann <martin@NetBSD.org>
Newsgroups: muc.lists.netbsd.source-changes
Subject: Re: CVS commit: src/sys/net
Date: Wed, 24 Jun 2026 11:15:46 +0000
Organization: Newsgate at muc.de e.V.
Sender: source-changes-d-owner@NetBSD.org
Approved: news-admin@muc.de
Distribution: world
Message-ID: <aju8YvdnOSKBllxA@homeworld.netbsd.org>
References: <20260624065604.1E4CFFA2B@cvs.NetBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Injection-Info: news.muc.de; posting-host="news.muc.de:193.149.48.2"; logging-data="12231"; mail-complaints-to="news-admin@muc.de"
Content-Disposition: inline
In-Reply-To: <20260624065604.1E4CFFA2B@cvs.NetBSD.org>
Precedence: bulk
Xref: csiph.com muc.lists.netbsd.source-changes:156182

On Wed, Jun 24, 2026 at 06:56:04AM +0000, Shoichi YAMAGUCHI wrote:
> Module Name:	src
> Committed By:	yamaguchi
> Date:		Wed Jun 24 06:56:04 UTC 2026
> 
> Modified Files:
> 	src/sys/net: if_spppsubr.c
> 
> Log Message:
> sppp: use atomic_loadstore(9) to read and write sp->pp_last_activity
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.292 -r1.293 src/sys/net/if_spppsubr.c

Sorry, but this breaks the build:

/work/src/sys/rump/net/lib/libnet/../../../../net/if_spppsubr.c: In function 'sp
pp_keepalive':
/work/src/sys/rump/net/lib/libnet/../../../../sys/atomic.h:427:9: note: in expansion of macro 'CTASSERT'
  427 |         CTASSERT(sizeof(*(p)) <= __ATOMIC_SIZE_MAX);                          \
      |         ^~~~~~~~

We do not have 64bit atomics on all architectures.

Does this have to be a 64bit value?

Martin

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-admin@muc.de