Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: "Levin, Alexander (Sasha Levin)" Newsgroups: linux.kernel Subject: [PATCH review for 4.9 29/50] qede: Prevent index problems in loopback test Date: Mon, 25 Sep 2017 03:40:02 +0200 Message-ID: References: X-Original-To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1506302040; x=1537838040; h=from:cc:to:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ugPLxYZ/J5mtsknXeGg7QsJ1EUlsCetbRBNCqqJh2CI=; b=kqMG4A97dR2hdRemSKKvBR3pDvG8RoVtUlY0hkxLIP+94+eUSfZDLt0z wHehrY8vsRHxjoNNYsCc3Sb0yCTIkyVEed2GPbjIuDoueOXnVY9JrmtxC Lm2RVZqPVkOd+0lyIrWB6OAisHhskRz1BxqyqodmRGT560xZgIrM2OcKQ g=; Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1506301980; x=1537837980; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ugPLxYZ/J5mtsknXeGg7QsJ1EUlsCetbRBNCqqJh2CI=; b=RgD5Zfm7TX13aqrcJMyXwaIyMR88zLLuzAjzLtsEgHb0WdRfCByt+B5y 5XmVnJyQ2UhN/LX9dFWtWPBEiOmstCmAvCI634cLo73X7qf4AjDLORb8C GLFPI7UMCq9uhXU+hhjztLWJoNG2pXM+3Vs8AK1lv4Hs03pEKE7U+Y7Uo I=; Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1506301978; x=1537837978; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ugPLxYZ/J5mtsknXeGg7QsJ1EUlsCetbRBNCqqJh2CI=; b=b3wrylurot8A7TiRv8pPHP8e2+4LfJZt4IFy1hfGjW836fBBYlqG1Waq +H/qnQf3J/PbvFgaTi07Tczo3p2oxV5HPTzkV9FTY22bnFRvg0BlQgWwT uoVRqD9IBpIx07avAcMLi+KPFpKDWHbrX5YGE/Sxig1tDrr3FGcmmvOpC 0=; X-Host: viking.odc.vzwcorp.com Thread-Topic: [PATCH review for 4.9 29/50] qede: Prevent index problems in loopback test Thread-Index: AQHTNZtpPgqBtJU1LkOAzLVT4CYvlA== Accept-Language: en-US Content-Language: en-US X-Ms-Exchange-Messagesentrepresentingtype: 1 X-Ms-Exchange-Transport-Fromentityheader: Hosted X-Originating-IP: [10.144.60.250] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 52 Organization: linux.* mail to news gateway X-Original-Cc: Sudarsana Reddy Kalluru , Yuval Mintz , "David S . Miller" , "Levin, Alexander (Sasha Levin)" X-Original-Date: Mon, 25 Sep 2017 01:12:52 +0000 X-Original-Message-ID: <20170925011225.10029-29-alexander.levin@verizon.com> X-Original-References: <20170925011225.10029-1-alexander.levin@verizon.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1738686 From: Sudarsana Reddy Kalluru [ Upstream commit afe981d664aeeebc8d1bcbd7d2070b5432edaecb ] Driver currently utilizes the same loop variable in two nested loops. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/= ethernet/qlogic/qede/qede_ethtool.c index 7567cc464b88..634e4149af22 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c +++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c @@ -1221,7 +1221,7 @@ static int qede_selftest_receive_traffic(struct qede_= dev *edev) struct qede_rx_queue *rxq =3D NULL; struct sw_rx_data *sw_rx_data; union eth_rx_cqe *cqe; - int i, rc =3D 0; + int i, iter, rc =3D 0; u8 *data_ptr; =20 for_each_queue(i) { @@ -1240,7 +1240,7 @@ static int qede_selftest_receive_traffic(struct qede_= dev *edev) * enabled. This is because the queue 0 is configured as the default * queue and that the loopback traffic is not IP. */ - for (i =3D 0; i < QEDE_SELFTEST_POLL_COUNT; i++) { + for (iter =3D 0; iter < QEDE_SELFTEST_POLL_COUNT; iter++) { if (!qede_has_rx_work(rxq)) { usleep_range(100, 200); continue; @@ -1287,7 +1287,7 @@ static int qede_selftest_receive_traffic(struct qede_= dev *edev) qed_chain_recycle_consumed(&rxq->rx_comp_ring); } =20 - if (i =3D=3D QEDE_SELFTEST_POLL_COUNT) { + if (iter =3D=3D QEDE_SELFTEST_POLL_COUNT) { DP_NOTICE(edev, "Failed to receive the traffic\n"); return -1; } --=20 2.11.0