Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: "Levin, Alexander (Sasha Levin)" Newsgroups: linux.kernel Subject: [PATCH review for 4.9 04/50] irqchip/crossbar: Fix incorrect type of local variables Date: Mon, 25 Sep 2017 03:40:01 +0200 Message-ID: References: Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1506302047; x=1537838047; h=from:cc:to:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=/AgoN25XpaBP8p+a2aX9lLt7EQMr2uZF/QLDH44epsI=; b=rAy63/T8sIrq1+WBHrT3rf/5k61g0b2XJFjacUG4MJaiaddfBNz93sbS /p1K8duKtyqF4inZQzJG8dcYV/t8D7v9fGZqfjhaKOIu+73or2ngrbAcP KDp3cJ9ggi3M65WhSur+dMJVM/pA24RaPekiYS1uun0cGrfo++US++as8 U=; Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1506301964; x=1537837964; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=/AgoN25XpaBP8p+a2aX9lLt7EQMr2uZF/QLDH44epsI=; b=sPYpBsE4VU3dUzJlukZMFo25AwgMTsPIbYA9on/0hs41z9z/goQDZA2o KIF1cKaDCFip9ogHC44Qp3a/un9bZFZ2W/0AseTJ+R2k651Ti9p0Fwi77 us+Pegck8dfn11xPn+Xm1gYzRG9PTJ6/RzVJo1tl9LVDSrmxx3QuLjba4 E=; Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1506301963; x=1537837963; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=/AgoN25XpaBP8p+a2aX9lLt7EQMr2uZF/QLDH44epsI=; b=dnjl0LrY/n30Iiwfm3mvtGZwmoMzHC5F7YpWn3C4J4+bfWQmSovQIYjE w5cNKxj/Zjvsvx+1ppjIunXYT+z+hK45nwfqwSr/0IQy1Uj9Kf6aU28gx VElFbc6RnUuhOSJvorcy0EWDpevjSe2FEOaE4TRQ9EjXgF1dfSEdf24OO 0=; X-Host: viking.odc.vzwcorp.com Thread-Topic: [PATCH review for 4.9 04/50] irqchip/crossbar: Fix incorrect type of local variables Thread-Index: AQHTNZtiEcT9XpazbEOL2Rwq7Kh75w== Accept-Language: en-US Content-Language: en-US X-Ms-Exchange-Messagesentrepresentingtype: 1 X-Ms-Exchange-Transport-Fromentityheader: Hosted X-Originating-IP: [10.144.60.250] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 53 Organization: linux.* mail to news gateway X-Original-Cc: Franck Demathieu , "marc.zyngier@arm.com" , "jason@lakedaemon.net" , "Thomas Gleixner" , "Levin, Alexander (Sasha Levin)" X-Original-Date: Mon, 25 Sep 2017 01:12:40 +0000 X-Original-Message-ID: <20170925011225.10029-4-alexander.levin@verizon.com> X-Original-References: <20170925011225.10029-1-alexander.levin@verizon.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1738684 From: Franck Demathieu [ Upstream commit b28ace12661fbcfd90959c1e84ff5a85113a82a1 ] The max and entry variables are unsigned according to the dt-bindings. Fix following 3 sparse issues (-Wtypesign): drivers/irqchip/irq-crossbar.c:222:52: warning: incorrect type in argumen= t 3 (different signedness) drivers/irqchip/irq-crossbar.c:222:52: expected unsigned int [usertype= ] *out_value drivers/irqchip/irq-crossbar.c:222:52: got int * drivers/irqchip/irq-crossbar.c:245:56: warning: incorrect type in argumen= t 4 (different signedness) drivers/irqchip/irq-crossbar.c:245:56: expected unsigned int [usertype= ] *out_value drivers/irqchip/irq-crossbar.c:245:56: got int * drivers/irqchip/irq-crossbar.c:263:56: warning: incorrect type in argumen= t 4 (different signedness) drivers/irqchip/irq-crossbar.c:263:56: expected unsigned int [usertype= ] *out_value drivers/irqchip/irq-crossbar.c:263:56: got int * Signed-off-by: Franck Demathieu Cc: marc.zyngier@arm.com Cc: jason@lakedaemon.net Link: http://lkml.kernel.org/r/20170223094855.6546-1-fdemathieu@gmail.com Signed-off-by: Thomas Gleixner Signed-off-by: Sasha Levin --- drivers/irqchip/irq-crossbar.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.= c index 1eef56a89b1f..05bbf171df37 100644 --- a/drivers/irqchip/irq-crossbar.c +++ b/drivers/irqchip/irq-crossbar.c @@ -198,7 +198,8 @@ static const struct irq_domain_ops crossbar_domain_ops = =3D { =20 static int __init crossbar_of_init(struct device_node *node) { - int i, size, max =3D 0, reserved =3D 0, entry; + int i, size, reserved =3D 0; + u32 max =3D 0, entry; const __be32 *irqsr; int ret =3D -ENOMEM; =20 --=20 2.11.0