Path: csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod From: Vineet Gupta Newsgroups: linux.kernel Subject: Re: [PATCH 2/5] ARC: AXS103: Get rid of platform specific cpu clock configuration Date: Tue, 22 Aug 2017 22:40:02 +0200 Message-ID: References: X-Original-To: Eugeniy Paltsev , "linux-snps-arc@lists.infradead.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.10.161.108] Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 29 Organization: linux.* mail to news gateway X-Original-Cc: "linux-kernel@vger.kernel.org" , "Alexey Brodkin" , Rob Herring , "Mark Rutland" , "devicetree@vger.kernel.org" X-Original-Date: Tue, 22 Aug 2017 13:39:04 -0700 X-Original-Message-ID: <0a4209a9-bf2e-c8a4-31b0-c08043d5e168@synopsys.com> X-Original-References: <20170814161213.17522-1-Eugeniy.Paltsev@synopsys.com> <20170814161213.17522-3-Eugeniy.Paltsev@synopsys.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1717819 On 08/14/2017 09:12 AM, Eugeniy Paltsev wrote: > We set AXS103 cpu frequency in arch/arc/plat-axs10x/axs10x.c > via direct writing to pll registers for historical reasons. > So get rid of AXS103 platform specific cpu clock configuration as > we have driver for AXS103 core pll (AXS103 pll driver is already > in linux-next. It is selected automatically when > CONFIG_ARC_PLAT_AXS10X is set) > > Signed-off-by: Eugeniy Paltsev > --- > arch/arc/plat-axs10x/axs10x.c | 88 ++----------------------------------------- > 1 file changed, 4 insertions(+), 84 deletions(-) > > diff --git a/arch/arc/plat-axs10x/axs10x.c b/arch/arc/plat-axs10x/axs10x.c > index 38ff349..98d07b7 100644 > --- a/arch/arc/plat-axs10x/axs10x.c > +++ b/arch/arc/plat-axs10x/axs10x.c > @@ -335,61 +335,12 @@ union pll_reg { > unsigned int val; > }; You forget to prune a bunch of code not needed anymore - pll_reg struct / write_cgu_reg .... I've fixed that up locally ! Nice cleanup ! Thx, -Vineet