Path: csiph.com!feeder.erje.net!1.eu.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod From: Rob Herring Newsgroups: linux.kernel Subject: Re: [patch v3 3/3] doccumentation: jtag: Add bindings for Aspeed SoC 24xx and 25xx families JTAG master driver Date: Thu, 17 Aug 2017 23:30:05 +0200 Message-ID: References: X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0JRmNkMmNv/Y6U50f4+Si6EBDnz546UBVNKAy/JZJ0c=; b=H0bY/Qi7AvafZkpeLMBA6uDdLrNb+X4JrmY+pOypG9K+Jv/XVvB9D0iiDW5qV7OB+h LrATNI7ZNw7BzoJlq5b3lsf7G8kjqm3nrucH6pie9AhB09jz2V1sYYwpOwMEvLU7NVj/ jKYgwuBECuweYmXEQZAqaLTvlWmayumPYnAGJelrGCua4sO2aYu+nxrFNo2Sb+Qc4u59 +3/7qJ7DqEW3f/VG0/NfTGxuEM0vQyImYxWCUhF0oCxYMQT9NETD2bjrs033cst9K9lC YPgTGwRhLc8Q349D/Wgz8hI4FLITy3UfECehAz9Vy2Z1il3AcXMQPVXff0lCxoDYXXzR BwpA== X-Gm-Message-State: AHYfb5hD5jhOYdBtB+yPTrPCsv2UtVhxLM6rZHAXPxEpIyQPnK5UjcXu ZoFr35LTHYg2Gw== X-Received: by 10.202.184.8 with SMTP id i8mr8822839oif.266.1503005077298; Thu, 17 Aug 2017 14:24:37 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 52 Organization: linux.* mail to news gateway X-Original-Cc: gregkh@linuxfoundation.org, arnd@arndb.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, openbmc@lists.ozlabs.org, joel@jms.id.au, jiri@resnulli.us, tklauser@distanz.ch, linux-serial@vger.kernel.org, mec@shout.net, vadimp@maellanox.com, system-sw-low-level@mellanox.com, openocd-devel-owner@lists.sourceforge.net, Jiri Pirko X-Original-Date: Thu, 17 Aug 2017 16:24:35 -0500 X-Original-Message-ID: <20170817212435.ypzsc3e6x2m4owyc@rob-hp-laptop> X-Original-References: <1502791207-26951-1-git-send-email-oleksandrs@mellanox.com> <1502791207-26951-4-git-send-email-oleksandrs@mellanox.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1714394 On Tue, Aug 15, 2017 at 01:00:07PM +0300, Oleksandr Shamray wrote: > It has been tested on Mellanox system with BMC equipped with > Aspeed 2520 SoC for programming CPLD devices. > > Signed-off-by: Oleksandr Shamray > Signed-off-by: Jiri Pirko > --- > v2->v3 > Comments pointed by Rob Herring > - split Aspeed jtag driver and binding to sepatrate patches > - delete unnecessary "status" and "reg-shift" descriptions in > bndings file > --- > .../devicetree/bindings/jtag/aspeed-jtag.txt | 19 +++++++++++++++++++ > 1 files changed, 19 insertions(+), 0 deletions(-) > create mode 100644 Documentation/devicetree/bindings/jtag/aspeed-jtag.txt > > diff --git a/Documentation/devicetree/bindings/jtag/aspeed-jtag.txt b/Documentation/devicetree/bindings/jtag/aspeed-jtag.txt > new file mode 100644 > index 0000000..4743d6d > --- /dev/null > +++ b/Documentation/devicetree/bindings/jtag/aspeed-jtag.txt > @@ -0,0 +1,19 @@ > +Aspeed JTAG driver for ast2400 and ast2500 SoC > + > +Required properties: > +- compatible: Should be one of > + - "aspeed,aspeed2400-jtag" > + - "aspeed,aspeed2500-jtag" > +- reg contains the offset and length of the JTAG memory > + region > +- clocks root clock of bus, should reference the APB clock > +- interrupts should contain JTAG controller interrupt > + > +Example: > +jtag: jtag@1e6e4000 { > + compatible = "aspeed,aspeed2500-jtag"; > + reg = <0x1e6e4000 0x1c>; > + reg-shift = <2>; Still here... Otherwise, Acked-by: Rob Herring > + clocks = <&clk_apb>; > + interrupts = <43>; > +}; > -- > 1.7.1 >