Path: csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod From: "Zheng, Lv" Newsgroups: linux.kernel Subject: RE: [PATCH 3/3] ACPI / scan: Enable GPEs before scanning the namespace Date: Tue, 15 Aug 2017 04:20:01 +0200 Message-ID: References: X-Extloop1: 1 X-Ironport-Av: E=Sophos;i="5.41,376,1498546800"; d="scan'208";a="1162637048" Thread-Topic: [PATCH 3/3] ACPI / scan: Enable GPEs before scanning the namespace Thread-Index: AQHTEWDc9PYC2GRiNEaKPlzp7VOGt6KEtFIQ Accept-Language: zh-CN, en-US Content-Language: en-US X-Titus-Metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzg5Zjc1NjctYzZhYS00ZTkxLTkwNmItM2UzYmJlNDRmODcxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlR1eUFnd2k3NWpHVnVPK3hCREQra0JyS3NyandxZWQxeWZkRFBvc2RuSjQ9In0= X-Ctpclassification: CTP_IC Dlp-Product: dlpe-windows Dlp-Version: 10.0.102.7 Dlp-Reaction: no-action X-Originating-IP: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 67 Organization: linux.* mail to news gateway X-Original-Cc: Mika Westerberg , Srinivas Pandruvada , Linux PCI , LKML , "Moore, Robert" X-Original-Date: Tue, 15 Aug 2017 02:12:24 +0000 X-Original-Message-ID: <1AE640813FDE7649BE1B193DEA596E886CF0AFE3@SHSMSX101.ccr.corp.intel.com> X-Original-References: <12346760.yAFCnkEgf6@aspire.rjw.lan> <6344941.kJ2o2XerZ0@aspire.rjw.lan> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1711767 Hi, Rafael > From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-owner@vger.kernel.org] On Behalf Of Rafael J. > Wysocki > Subject: [PATCH 3/3] ACPI / scan: Enable GPEs before scanning the namespace > > From: Rafael J. Wysocki > > On some systems the platform firmware expects GPEs to be enabled > before the enumeration of devices and if that expectation is not > met, the systems in question may not boot in some situations. > > For this reason, change the initialization ordering of the ACPI > subsystem to make it enable GPEs before scanning the namespace > for the first time in order to enumerate devices. > > Reported-by: Mika Westerberg > Suggested-by: Mika Westerberg > Signed-off-by: Rafael J. Wysocki > --- > drivers/acpi/scan.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > Index: linux-pm/drivers/acpi/scan.c > =================================================================== > --- linux-pm.orig/drivers/acpi/scan.c > +++ linux-pm/drivers/acpi/scan.c > @@ -2139,6 +2139,10 @@ int __init acpi_scan_init(void) > acpi_get_spcr_uart_addr(); > } > > + acpi_gpe_apply_masked_gpes(); > + acpi_update_all_gpes(); > + acpi_ec_ecdt_start(); > + Just for your information. A recent internal bug reveals that acpi_ec_ecdt_start() should only be invoked after the enumeration (acpi_ec_add()) for now. The function contains logics that need to be altered by acpi_ec_add(). So it seems we can only do less aggressive change by moving the GPE related 2 lines up. Thanks and best regards Lv > mutex_lock(&acpi_scan_lock); > /* > * Enumerate devices in the ACPI namespace. > @@ -2163,10 +2167,6 @@ int __init acpi_scan_init(void) > } > } > > - acpi_gpe_apply_masked_gpes(); > - acpi_update_all_gpes(); > - acpi_ec_ecdt_start(); > - > acpi_scan_initialized = true; > > out: > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html