Path: csiph.com!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod From: tip-bot for Arnaldo Carvalho de Melo Newsgroups: linux.kernel Subject: [tip:perf/core] perf trace beauty fcntl: Beautify F_GETFL return value Date: Thu, 20 Jul 2017 10:50:03 +0200 Message-ID: X-Original-To: linux-tip-commits@vger.kernel.org Reply-To: wangnan0@huawei.com, acme@redhat.com, jolsa@kernel.org, adrian.hunter@intel.com, namhyung@kernel.org, tglx@linutronix.de, mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org, dsahern@gmail.com Git-Commit-ID: 89e8524abe1c584942e6b05744946877e87dd478 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 51 Organization: linux.* mail to news gateway X-Original-Cc: jolsa@kernel.org, wangnan0@huawei.com, acme@redhat.com, linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com, dsahern@gmail.com, tglx@linutronix.de, adrian.hunter@intel.com, namhyung@kernel.org X-Original-Date: Thu, 20 Jul 2017 01:43:03 -0700 X-Original-Message-ID: X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1692591 Commit-ID: 89e8524abe1c584942e6b05744946877e87dd478 Gitweb: http://git.kernel.org/tip/89e8524abe1c584942e6b05744946877e87dd478 Author: Arnaldo Carvalho de Melo AuthorDate: Fri, 14 Jul 2017 12:14:20 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 18 Jul 2017 23:13:59 -0300 perf trace beauty fcntl: Beautify F_GETFL return value The return for fcntl(fd, F_GETFL) is the fd file flags, so reuse the one for the open syscall flags parameter: 997.992 (0.002 ms): Chrome_IOThrea/19863 fcntl(fd: 144, cmd: GETFL) = RDWR|LARGEFILE Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-5nn3n4p4yfs6u0leoq880apc@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/trace/beauty/fcntl.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/perf/trace/beauty/fcntl.c b/tools/perf/trace/beauty/fcntl.c index 8a5f58d..8dcbc30 100644 --- a/tools/perf/trace/beauty/fcntl.c +++ b/tools/perf/trace/beauty/fcntl.c @@ -11,13 +11,19 @@ size_t syscall_arg__scnprintf_fcntl_cmd(char *bf, size_t size, struct syscall_arg *arg) { + if (arg->val == F_GETFL) { + syscall_arg__set_ret_scnprintf(arg, open__scnprintf_flags); + goto mask_arg; + } /* * Some commands ignore the third fcntl argument, "arg", so mask it */ - if (arg->val == F_GETFD || arg->val == F_GETFL || + if (arg->val == F_GETFD || arg->val == F_GETOWN || arg->val == F_GET_SEALS || - arg->val == F_GETLEASE || arg->val == F_GETSIG) + arg->val == F_GETLEASE || arg->val == F_GETSIG) { +mask_arg: arg->mask |= (1 << 2); + } return syscall_arg__scnprintf_strarrays(bf, size, arg); }