Path: csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: tip-bot for Arnaldo Carvalho de Melo Newsgroups: linux.kernel Subject: [tip:perf/core] perf trace beauty fcntl: Beautify F_GETOWN and F_SETOWN Date: Thu, 20 Jul 2017 10:50:02 +0200 Message-ID: X-Original-To: linux-tip-commits@vger.kernel.org Reply-To: adrian.hunter@intel.com, mingo@kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org, dsahern@gmail.com, hpa@zytor.com, namhyung@kernel.org, tglx@linutronix.de, acme@redhat.com, wangnan0@huawei.com Git-Commit-ID: 1a4ad26393bc73d3294bb7919cb4cd2dfffbe57c X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 53 Organization: linux.* mail to news gateway X-Original-Cc: dsahern@gmail.com, wangnan0@huawei.com, hpa@zytor.com, namhyung@kernel.org, acme@redhat.com, tglx@linutronix.de, adrian.hunter@intel.com, jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org X-Original-Date: Thu, 20 Jul 2017 01:45:44 -0700 X-Original-Message-ID: X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1692580 Commit-ID: 1a4ad26393bc73d3294bb7919cb4cd2dfffbe57c Gitweb: http://git.kernel.org/tip/1a4ad26393bc73d3294bb7919cb4cd2dfffbe57c Author: Arnaldo Carvalho de Melo AuthorDate: Fri, 14 Jul 2017 15:39:40 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 18 Jul 2017 23:14:04 -0300 perf trace beauty fcntl: Beautify F_GETOWN and F_SETOWN By attaching the pid beautifier to the args in the F_SETOWN case and to the syscall return on the F_GETOWN one. Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-ea1prtqvao87cdrishce7954@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/trace/beauty/fcntl.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/perf/trace/beauty/fcntl.c b/tools/perf/trace/beauty/fcntl.c index 254ae435..d082fd2 100644 --- a/tools/perf/trace/beauty/fcntl.c +++ b/tools/perf/trace/beauty/fcntl.c @@ -34,10 +34,14 @@ size_t syscall_arg__scnprintf_fcntl_cmd(char *bf, size_t size, struct syscall_ar syscall_arg__set_ret_scnprintf(arg, syscall_arg__scnprintf_fd); goto out; } + if (arg->val == F_GETOWN) { + syscall_arg__set_ret_scnprintf(arg, syscall_arg__scnprintf_pid); + goto mask_arg; + } /* * Some commands ignore the third fcntl argument, "arg", so mask it */ - if (arg->val == F_GETOWN || arg->val == F_GET_SEALS || + if (arg->val == F_GET_SEALS || arg->val == F_GETLEASE || arg->val == F_GETSIG) { mask_arg: arg->mask |= (1 << 2); @@ -55,6 +59,9 @@ size_t syscall_arg__scnprintf_fcntl_arg(char *bf, size_t size, struct syscall_ar if (cmd == F_SETFL) return open__scnprintf_flags(arg->val, bf, size); + + if (cmd == F_SETOWN) + return syscall_arg__scnprintf_pid(bf, size, arg); /* * We still don't grab the contents of pointers on entry or exit, * so just print them as hex numbers