Path: csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From: Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups: linux.kernel
Subject: Re: [PATCH perf/urgent] perf tools: Fix the code to strip command  name
Date: Mon, 24 Apr 2017 18:30:02 +0200
Message-ID: <tzP2a-Rd-23@gated-at.bofh.it>
References: <tygzw-7a4-7@gated-at.bofh.it> <tzOpr-mK-7@gated-at.bofh.it> <tzOIO-JE-15@gated-at.bofh.it>
X-Original-To: Jiri Olsa <jolsa@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-URL: http://acmel.wordpress.com
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: robomod@news.nic.it
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Approved: robomod@news.nic.it
Lines: 34
Organization: linux.* mail to news gateway
X-Original-Cc: Jiri Olsa <jolsa@kernel.org>, David Ahern <dsahern@gmail.com>, Namhyung Kim <namhyung@kernel.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>, Taeung Song <treeze.taeung@gmail.com>, Jin Yao <yao.jin@linux.intel.com>, lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>
X-Original-Date: Mon, 24 Apr 2017 13:28:39 -0300
X-Original-Message-ID: <20170424162839.GC2742@kernel.org>
X-Original-References: <20170420092430.29657-1-jolsa@kernel.org> <20170424154450.GB2742@kernel.org> <20170424160645.GA4120@krava>
X-Original-Sender: linux-kernel-owner@vger.kernel.org
Xref: csiph.com linux.kernel:1629766

Em Mon, Apr 24, 2017 at 06:06:45PM +0200, Jiri Olsa escreveu:
> On Mon, Apr 24, 2017 at 12:44:50PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Apr 20, 2017 at 11:24:30AM +0200, Jiri Olsa escreveu:
> > > Recent commit broke command name strip in perf_event__get_comm_ids
> > > function. It replaced left to right search for '\n' with rtrim,
> > > which actually does right to left search. It occasionally caught
> > > earlier '\n' and kept trash in the command name.
> > > 
> > > Keeping the ltrim, but moving back the left to right '\n' search
> > > instead of the rtrim.
> > 
> > perf/urgent?
> >  
> > > Fixes: bdd97ca63faa ("perf tools: Refactor the code to strip command name with {l,r}trim()")
> > 
> > [acme@jouet linux]$ git tag --contains bdd97ca63faa
> > perf-core-for-mingo-4.12-20170411
> > perf-core-for-mingo-4.12-20170413
> > perf-core-for-mingo-4.12-20170419
> > [acme@jouet linux]$ 
> > 
> > It is just in tip/perf/core, will put in acme/perf/core and push to Ingo
> > in my next pull req.
> 
> sure, I did not check.. just thought it's urgent from time POV ;-)

:-)

I took it too literally then, tried to apply it to perf/urgent, it
failed, scratched my head...

Anyway, applied.

- Arnaldo