Path: csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod From: Marcel Holtmann Newsgroups: linux.kernel Subject: Re: [PATCH] Bluetooth: hci_bcm: Fix clock (un)prepare Date: Mon, 27 Mar 2017 16:10:03 +0200 Message-ID: References: Content-Type: text/plain; charset=us-ascii MIME-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Content-Transfer-Encoding: 7bit X-Mailer: Apple Mail (2.3259) Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 16 Organization: linux.* mail to news gateway X-Original-Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo F. Padovan" , Johan Hedberg X-Original-Date: Mon, 27 Mar 2017 16:07:25 +0200 X-Original-Message-ID: <7BBF08AA-EFD1-4330-BAA0-F6B2EEF5D63E@holtmann.org> X-Original-References: <20170315122005.7702-1-john@metanate.com> <20170315122005.7702-2-john@metanate.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1609870 Hi John, > The hci_bcm driver currently does not prepare/unprepare the clock and > goes directly to enable, but as the documentation for clk_enable says, > clk_prepare must be called before clk_enable. > > Signed-off-by: John Keeping > --- > drivers/bluetooth/hci_bcm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel