Path: csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod From: Richard Leitner Newsgroups: linux.kernel Subject: Re: [PATCH 2/2] nvmem: imx-ocotp: add write support Date: Mon, 27 Mar 2017 16:10:02 +0200 Message-ID: References: Authentication-Results: mail2.skidata.com; spf=None smtp.pra=richard.leitner@skidata.com; spf=PermError smtp.mailfrom=Richard.Leitner@skidata.com; spf=None smtp.helo=postmaster@sdmr1srv.skidata.net Received-Spf: None (mail2.skidata.com: no sender authenticity information available from domain of richard.leitner@skidata.com) identity=pra; client-ip=172.16.10.74; receiver=mail2.skidata.com; envelope-from="Richard.Leitner@skidata.com"; x-sender="richard.leitner@skidata.com"; x-conformance=sidf_compatible Received-Spf: PermError (mail2.skidata.com: cannot correctly interpret sender authenticity information from domain of Richard.Leitner@skidata.com) identity=mailfrom; client-ip=172.16.10.74; receiver=mail2.skidata.com; envelope-from="Richard.Leitner@skidata.com"; x-sender="Richard.Leitner@skidata.com"; x-conformance=sidf_compatible; x-record-type="v=spf1" Received-Spf: None (mail2.skidata.com: no sender authenticity information available from domain of postmaster@sdmr1srv.skidata.net) identity=helo; client-ip=172.16.10.74; receiver=mail2.skidata.com; envelope-from="Richard.Leitner@skidata.com"; x-sender="postmaster@sdmr1srv.skidata.net"; x-conformance=sidf_compatible X-Ironport-Anti-Spam-Filtered: true X-Ironport-Anti-Spam-Result: =?us-ascii?q?A2E4BAA8GtlY/0oKEKxcGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBhUAHg1ubPR8QkyyCD4IOhiICg1MXAQIBAQEBAQEBA4EQhRYBBSM?= =?us-ascii?q?PAUYQCw0BCgICJgICRxAGAQwBBQICtViCJiYCihIBAQEBAQEBAQEBAQEBAQEBA?= =?us-ascii?q?QEBHwkBgQGFQ4IFCIJih1qCXwEEnFuCBZJDiF4XDIY0k2UhAoE5EhIRBR+HMHO?= =?us-ascii?q?IKIENAQEB?= X-Ipas-Result: =?us-ascii?q?A2E4BAA8GtlY/0oKEKxcGQEBAQEBAQEBAQEBBwEBAQEBhUA?= =?us-ascii?q?Hg1ubPR8QkyyCD4IOhiICg1MXAQIBAQEBAQEBA4EQhRYBBSMPAUYQCw0BCgICJ?= =?us-ascii?q?gICRxAGAQwBBQICtViCJiYCihIBAQEBAQEBAQEBAQEBAQEBAQEBHwkBgQGFQ4I?= =?us-ascii?q?FCIJih1qCXwEEnFuCBZJDiF4XDIY0k2UhAoE5EhIRBR+HMHOIKIENAQEB?= X-Ironport-Av: E=Sophos;i="5.36,231,1486422000"; d="scan'208";a="499539" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [172.16.60.30] X-Clientproxiedby: sdex1srv.skidata.net (172.16.10.92) To sdex1srv.skidata.net (172.16.10.92) Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 22 Organization: linux.* mail to news gateway X-Original-Cc: linux-kernel , Srinivas Kandagatla , Maxime Ripard , "robh+dt@kernel.org" , Mark Rutland , "devicetree@vger.kernel.org" , X-Original-Date: Mon, 27 Mar 2017 15:59:17 +0200 X-Original-Message-ID: <8a1caa0b-8117-4e2f-1782-a9251f617969@skidata.com> X-Original-References: <1490621491-28247-1-git-send-email-richard.leitner@skidata.com> <1490621491-28247-2-git-send-email-richard.leitner@skidata.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1609866 On 03/27/2017 03:42 PM, Fabio Estevam wrote: > [Adding Pengutronix folks and Shawn on Cc] > > On Mon, Mar 27, 2017 at 10:31 AM, Richard Leitner > wrote: >> Implement write routine for OCOTP controller found in i.MX6 SoC's. >> Furthermore add locking to the read function to prevent race conditions. >> The write routine code is based on the fsl_otp driver from Freescale. >> >> Signed-off-by: Richard Leitner > > Do we really want to have write support in the driver? We need it for our "factory startup" process and other fusebox drivers support it as well. Therefore I thought it would be a good idea to bring it upstream. Furthermore you can disable it via devicetree (and it would also be possible to introduce a CONFIG for write support if it's wanted). kind regards, Richard L