Path: csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod From: Jeffy Chen Newsgroups: linux.kernel Subject: [PATCH v3 1/2] PCI: return resource_entry in pci_add_resource helpers Date: Fri, 24 Mar 2017 03:00:02 +0100 Message-ID: References: X-Original-To: linux-kernel@vger.kernel.org X-263anti-Spam: KSV:0; X-Mail-Delivery: 1 X-Abs-Checked: 4 X-Rl-Sender: jeffy.chen@rock-chips.com X-Fst-To: linux-kernel@vger.kernel.org X-Sender-IP: 103.29.142.67 X-Login-Name: jeffy.chen@rock-chips.com X-Unique-Tag: X-Sender: cjf@rock-chips.com X-Mailer: git-send-email 2.1.4 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 69 Organization: linux.* mail to news gateway X-Original-Cc: robh@kernel.org, toshi.kani@hpe.com, shawn.lin@rock-chips.com, briannorris@chromium.org, dianders@chromium.org, bhelgaas@google.com, dtor@chromium.org, Jeffy Chen , linux-pci@vger.kernel.org X-Original-Date: Fri, 24 Mar 2017 09:50:40 +0800 X-Original-Message-ID: <1490320241-9250-2-git-send-email-jeffy.chen@rock-chips.com> X-Original-References: <1490320241-9250-1-git-send-email-jeffy.chen@rock-chips.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1608076 Signed-off-by: Jeffy Chen --- Changes in v3: None Changes in v2: None drivers/pci/bus.c | 13 ++++++++----- include/linux/pci.h | 8 +++++--- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c index bc56cf1..36a1861 100644 --- a/drivers/pci/bus.c +++ b/drivers/pci/bus.c @@ -17,25 +17,28 @@ #include "pci.h" -void pci_add_resource_offset(struct list_head *resources, struct resource *res, - resource_size_t offset) +struct resource_entry *pci_add_resource_offset(struct list_head *resources, + struct resource *res, + resource_size_t offset) { struct resource_entry *entry; entry = resource_list_create_entry(res, 0); if (!entry) { printk(KERN_ERR "PCI: can't add host bridge window %pR\n", res); - return; + return NULL; } entry->offset = offset; resource_list_add_tail(entry, resources); + return entry; } EXPORT_SYMBOL(pci_add_resource_offset); -void pci_add_resource(struct list_head *resources, struct resource *res) +struct resource_entry *pci_add_resource(struct list_head *resources, + struct resource *res) { - pci_add_resource_offset(resources, res, 0); + return pci_add_resource_offset(resources, res, 0); } EXPORT_SYMBOL(pci_add_resource); diff --git a/include/linux/pci.h b/include/linux/pci.h index eb3da1a..ab16abe 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -1167,9 +1167,11 @@ void pci_release_selected_regions(struct pci_dev *, int); /* drivers/pci/bus.c */ struct pci_bus *pci_bus_get(struct pci_bus *bus); void pci_bus_put(struct pci_bus *bus); -void pci_add_resource(struct list_head *resources, struct resource *res); -void pci_add_resource_offset(struct list_head *resources, struct resource *res, - resource_size_t offset); +struct resource_entry *pci_add_resource(struct list_head *resources, + struct resource *res); +struct resource_entry *pci_add_resource_offset(struct list_head *resources, + struct resource *res, + resource_size_t offset); void pci_free_resource_list(struct list_head *resources); void pci_bus_add_resource(struct pci_bus *bus, struct resource *res, unsigned int flags); -- 2.1.4