Path: csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From: Philipp Zabel <p.zabel@pengutronix.de>
Newsgroups: linux.kernel
Subject: Re: [PATCH 1/2] reset: Add API to count number of reset available  with device
Date: Wed, 15 Mar 2017 11:50:02 +0100
Message-ID: <tleFc-6nm-5@gated-at.bofh.it>
References: <tdxEZ-551-5@gated-at.bofh.it> <tju1H-5nB-5@gated-at.bofh.it>
X-Original-To: Vivek Gautam <vivek.gautam@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.9-1+b1
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Sa-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17
X-Sa-Exim-Mail-From: p.zabel@pengutronix.de
X-Sa-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-Ptx-Original-Recipient: linux-kernel@vger.kernel.org
Sender: robomod@news.nic.it
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Approved: robomod@news.nic.it
Lines: 59
Organization: linux.* mail to news gateway
X-Original-Cc: Felipe Balbi <balbi@kernel.org>, Greg KH <gregkh@linuxfoundation.org>, Linux USB Mailing List <linux-usb@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, linux-arm-msm@vger.kernel.org
X-Original-Date: Wed, 15 Mar 2017 11:40:10 +0100
X-Original-Message-ID: <1489574410.2528.8.camel@pengutronix.de>
X-Original-References: <1487741048-24659-1-git-send-email-vivek.gautam@codeaurora.org> <CAFp+6iFRoQcKQwp5mwdjzKqoZHQzwkJxCRQRRWmnPeTxBHok5g@mail.gmail.com>
X-Original-Sender: linux-kernel-owner@vger.kernel.org
Xref: csiph.com linux.kernel:1601260

Hi Vivek,

On Fri, 2017-03-10 at 20:10 +0530, Vivek Gautam wrote:
> Hi Philipp,
> 
> 
> On Wed, Feb 22, 2017 at 10:54 AM, Vivek Gautam
> <vivek.gautam@codeaurora.org> wrote:
> > Count number of reset phandles available with the device node
> > to know the resets a given device has.
> >
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
> > ---
> 
> Any thoughts on this change?
> A small addition that seems useful.

Sorry I missed this one earlier.

> >
> > Based on torvald's master branch.
> >
> >  include/linux/reset.h | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/include/linux/reset.h b/include/linux/reset.h
> > index 5daff15722d3..88f63a640153 100644
> > --- a/include/linux/reset.h
> > +++ b/include/linux/reset.h
> > @@ -2,6 +2,7 @@
> >  #define _LINUX_RESET_H_
> >
> >  #include <linux/device.h>
> > +#include <linux/of.h>
> >
> >  struct reset_control;
> >
> > @@ -234,6 +235,21 @@ static inline struct reset_control *of_reset_control_get_shared_by_index(
> >  }
> >
> >  /**
> > + * of_reset_control_get_count - Count number of resets available with a device
> > + * @node: device to be reset by the controller
> > + */
> > +static inline unsigned int of_reset_control_get_count(struct device_node *node)
> > +{
> > +       int count;
> > +
> > +       count = of_count_phandle_with_args(node, "resets", "#reset-cells");
> > +       if (count < 0)
> > +               return 0;

Please don't silently ignore errors. gpiod_count doesn't ignore errors
either. tegra_powergate_of_resets in drivers/soc/tegra/pmc.c open codes
this, too. This should be changed so it can be used there, too.

regards
Philipp