Path: csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod From: Doug Berger Newsgroups: linux.kernel Subject: [PATCH net-next 08/12] net: bcmgenet: correct return value of __bcmgenet_tx_reclaim Date: Tue, 14 Mar 2017 01:50:02 +0100 Message-ID: References: Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FGTwuzj7oypG5gkwlYmWGM2WhPa1RkPMsQ3CirlRWrc=; b=PHHDwRIrOA9sJjarEGJRlx6E8nstvwtYd55oNtLknaDPYrBPsjVjqErRpWklIUulBi KQlVvJTskP1md4K8qwppgZuuNjSxDlT9YcyugPuEiH4FTnm5uDqgah1azpqNo/TxA1ba cNWN8koZx7LMCkGk1KJ+ew8N4RJBrmw0+Yjgpn9+3dE5eTHuzveUyRGGGYjBf5pgjJtp k17R7Kja3N3EXnq5HtRcHtGJHNYmGGWfnojpVCfkjc0fM7jMaAVAIRuVaVZzIB1R9Nmp VEPalBX8ysfe6h9dL8pGoH4J9tIzspv5DVVKA4nr9OEPHBgq7zP8IG6hIP8eCwRjFGd2 3+EA== X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FGTwuzj7oypG5gkwlYmWGM2WhPa1RkPMsQ3CirlRWrc=; b=bSI0+sBxSNvu4W/1b5/eZHx41PtZiPOOG/xwaiw8Sp4C5NMQefoT1UDxpT7qq7fkV+ klsJELM1lMBjjXEKzueV3iaFzYvuEsxdqHdu3j9C2kn2yNLmzvrzLMcK8crKwmOGzVlu 0Hm4LM9tv+ZujsDSE0bQlgNyI1aeSxE/D1Zkf2XERlZ473wLLuN1tVgx3CkhzeuhKncB pdkzQjVyO+ZfCoREBV33lMVguFSaY+l02gk2VLZaQlVTukchwKJ8Lp0DYs9d0WL1MPLG vKPxZGkVPzz+pWHijXRUpBQXiB4WPib8KvEKDvct7HPSXug9uzHutjSR14/Fa+rm7nI+ TtBw== X-Gm-Message-State: AFeK/H2nkI/vfrjg239i60wQuLz7GZsjieDZvXqb0aTWW4nhuYBohumOi7167SAUdB10FA== X-Received: by 10.55.77.79 with SMTP id a76mr33074638qkb.127.1489452140355; Mon, 13 Mar 2017 17:42:20 -0700 (PDT) X-Mailer: git-send-email 2.11.1 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 38 Organization: linux.* mail to news gateway X-Original-Cc: robh+dt@kernel.org, mark.rutland@arm.com, davem@davemloft.net, rafal@milecki.pl, xow@google.com, joel@jms.id.au, jon.mason@broadcom.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, pgynther@google.com, jaedon.shin@gmail.com, Doug Berger X-Original-Date: Mon, 13 Mar 2017 17:41:38 -0700 X-Original-Message-ID: <20170314004142.4746-9-opendmb@gmail.com> X-Original-References: <20170314004142.4746-1-opendmb@gmail.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1599956 The reclaim function should return the number of buffer descriptors reclaimed, not just the number corresponding to skb packets. Also, remove the unnecessary computation when updating the consumer index. While this is not a functional problem it could degrade performance of napi in a fragmented transmit stream. Signed-off-by: Doug Berger --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index 1f94ba1773dd..d90d366b286f 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -1218,7 +1218,7 @@ static unsigned int __bcmgenet_tx_reclaim(struct net_device *dev, } ring->free_bds += txbds_processed; - ring->c_index = (ring->c_index + txbds_processed) & DMA_C_INDEX_MASK; + ring->c_index = c_index; dev->stats.tx_packets += pkts_compl; dev->stats.tx_bytes += bytes_compl; @@ -1231,7 +1231,7 @@ static unsigned int __bcmgenet_tx_reclaim(struct net_device *dev, netif_tx_wake_queue(txq); } - return pkts_compl; + return txbds_processed; } static unsigned int bcmgenet_tx_reclaim(struct net_device *dev, -- 2.11.1