Path: csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.us.feeder.erje.net!news.glorb.com!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From: kbuild test robot <lkp@intel.com>
Newsgroups: linux.kernel
Subject: [PATCH] block: DAC960: fix ifnullfree.cocci warnings
Date: Sat, 11 Mar 2017 08:20:02 +0100
Message-ID: <tjJtM-7Li-9@gated-at.bofh.it>
References: <tjJtM-7Li-7@gated-at.bofh.it> <tiMDp-Dj-61@gated-at.bofh.it>
X-Extloop1: 1
X-Ironport-Av: E=Sophos;i="5.36,145,1486454400"; d="scan'208";a="234830195"
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Sa-Exim-Connect-IP: <locally generated>
X-Sa-Exim-Mail-From: fengguang.wu@intel.com
X-Sa-Exim-Scanned: No (on bee); SAEximRunCond expanded to false
Sender: robomod@news.nic.it
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Approved: robomod@news.nic.it
Lines: 36
Organization: linux.* mail to news gateway
X-Original-Cc: kbuild-all@01.org, Dan Williams <dan.j.williams@intel.com>, Doug Ledford <dledford@redhat.com>, Sean Hefty <sean.hefty@intel.com>, Hal Rosenstock <hal.rosenstock@gmail.com>, jeffrey.t.kirsher@intel.com, "David S. Miller" <davem@davemloft.net>, stas.yakovlev@gmail.com, "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, Felipe Balbi <balbi@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Romain Perier <romain.perier@collabora.com>, Peter Senna Tschudin <peter.senna@collabora.co.uk>
X-Original-Date: Sat, 11 Mar 2017 15:15:21 +0800
X-Original-Message-ID: <20170311071521.GA16525@lkp-wsm-ep1>
X-Original-References: <201703111417.0LzAlMy8%fengguang.wu@intel.com> <20170308161957.28941-2-romain.perier@collabora.com>
X-Original-Sender: linux-kernel-owner@vger.kernel.org
Xref: csiph.com linux.kernel:1598284

drivers/block/DAC960.c:441:3-19: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
drivers/block/DAC960.c:446:1-17: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

CC: Romain Perier <romain.perier@collabora.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 DAC960.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- a/drivers/block/DAC960.c
+++ b/drivers/block/DAC960.c
@@ -437,13 +437,11 @@ static void DAC960_DestroyAuxiliaryStruc
       Controller->CurrentStatusBuffer = NULL;
     }
 
-  if (ScatterGatherPool != NULL)
-  	dma_pool_destroy(ScatterGatherPool);
+  dma_pool_destroy(ScatterGatherPool);
   if (Controller->FirmwareType == DAC960_V1_Controller)
   	return;
 
-  if (RequestSensePool != NULL)
-	dma_pool_destroy(RequestSensePool);
+  dma_pool_destroy(RequestSensePool);
 
   for (i = 0; i < DAC960_MaxLogicalDrives; i++) {
 	kfree(Controller->V2.LogicalDeviceInformation[i]);