Path: csiph.com!feeder.erje.net!2.eu.feeder.erje.net!news.in-chemnitz.de!news2.arglkargh.de!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From: "Madhani, Himanshu" <Himanshu.Madhani@cavium.com>
Newsgroups: linux.kernel
Subject: RE: [PATCH] qla2xxx: Fix ql_dump_buffer
Date: Fri, 03 Mar 2017 20:30:02 +0100
Message-ID: <th13Q-5HD-29@gated-at.bofh.it>
References: <tgK2Z-26x-13@gated-at.bofh.it>
Thread-Topic: [PATCH] qla2xxx: Fix ql_dump_buffer
Thread-Index: AQHSk7uVaq66MBWbj0SbPeOgWi4qDaGDf6Dg
Accept-Language: en-US
Content-Language: en-US
Spamdiagnosticoutput: 1:99
Spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Ms-Exchange-Crosstenant-Originalarrivaltime: 03 Mar 2017 19:23:42.2691 (UTC)
X-Ms-Exchange-Crosstenant-Fromentityheader: Hosted
X-Ms-Exchange-Crosstenant-ID: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-Ms-Exchange-Transport-Crosstenantheadersstamped: SN1PR0701MB1839
Sender: robomod@news.nic.it
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Approved: robomod@news.nic.it
Lines: 59
Organization: linux.* mail to news gateway
X-Original-Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date: Fri, 3 Mar 2017 19:23:42 +0000
X-Original-Message-ID: <SN1PR0701MB183741685AF2616384EB5A42F52B0@SN1PR0701MB1837.namprd07.prod.outlook.com>
X-Original-References: <404b1c3a4bfd1f83211482b77b4a9680e755e32a.1488503664.git.joe@perches.com>
X-Original-Sender: linux-kernel-owner@vger.kernel.org
Xref: csiph.com linux.kernel:1592242



> -----Original Message-----
> From: Joe Perches [mailto:joe@perches.com]
> Sent: Thursday, March 2, 2017 5:15 PM
> To: qla2xxx-upstream@qlogic.com
> Cc: James E.J. Bottomley <jejb@linux.vnet.ibm.com>; Martin K. Petersen
> <martin.petersen@oracle.com>; linux-scsi@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] qla2xxx: Fix ql_dump_buffer
>=20
> Recent printk changes for KERN_CONT cause this logging to be defectively
> emitted on multiple lines.  Fix it.
>=20
> Also reduces object size a trivial amount.
>=20
> $ size drivers/scsi/qla2xxx/qla_dbg.o*
>    text	   data	    bss	    dec	    hex	filename
>   39125	      0	      0	  39125	   98d5	drivers/scsi/qla2xxx/qla_dbg.o.ne=
w
>   39164	      0	      0	  39164	   98fc	drivers/scsi/qla2xxx/qla_dbg.o.ol=
d
>=20
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/scsi/qla2xxx/qla_dbg.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
>=20
> diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_db=
g.c
> index 21d9fb7fc887..51b4179469d1 100644
> --- a/drivers/scsi/qla2xxx/qla_dbg.c
> +++ b/drivers/scsi/qla2xxx/qla_dbg.c
> @@ -2707,13 +2707,9 @@ ql_dump_buffer(uint32_t level, scsi_qla_host_t
> *vha, int32_t id,
>  	    "%-+5d  0  1  2  3  4  5  6  7  8  9  A  B  C  D  E  F\n", size);
>  	ql_dbg(level, vha, id,
>  	    "----- -----------------------------------------------\n");
> -	for (cnt =3D 0; cnt < size; cnt++, buf++) {
> -		if (cnt % 16 =3D=3D 0)
> -			ql_dbg(level, vha, id, "%04x:", cnt & ~0xFU);
> -		printk(" %02x", *buf);
> -		if (cnt % 16 =3D=3D 15)
> -			printk("\n");
> +	for (cnt =3D 0; cnt < size; cnt +=3D 16) {
> +		ql_dbg(level, vha, id, "%04x: ", cnt);
> +		print_hex_dump(KERN_CONT, "", DUMP_PREFIX_NONE, 16,
> 1,
> +			       buf + cnt, min(16U, size - cnt), false);
>  	}
> -	if (cnt % 16 !=3D 0)
> -		printk("\n");
>  }
> --
> 2.10.0.rc2.1.g053435c

Looks Good.=20

Acked-by: Himanshu Madhani <himanshu.madhani@cavium.com>