Path: csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod From: Boris Brezillon Newsgroups: linux.kernel Subject: Re: [PATCH v2 2/3] drm/vc4: Add HDMI audio support Date: Tue, 28 Feb 2017 14:20:03 +0100 Message-ID: References: X-Original-To: Eric Anholt X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 26 Organization: linux.* mail to news gateway X-Original-Cc: Lee Jones , Florian Fainelli , dri-devel@lists.freedesktop.org, Mark Brown , Liam Girdwood , Lars-Peter Clausen , alsa-devel@alsa-project.org, Stefan Wahren , Stephen Warren , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org X-Original-Date: Tue, 28 Feb 2017 10:19:17 +0100 X-Original-Message-ID: <20170228101917.40810aa9@bbrezillon> X-Original-References: <20170227202803.12855-1-eric@anholt.net> <20170227202803.12855-2-eric@anholt.net> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1589438 On Mon, 27 Feb 2017 12:28:02 -0800 Eric Anholt wrote: > The HDMI encoder IP embeds all needed blocks to output audio, with a > custom DAI called MAI moving audio between the two parts of the HDMI > core. This driver now exposes a sound card to let users stream audio > to their display. > > Using the hdmi-codec driver has been considered here, but MAI meant > having to significantly rework hdmi-codec, and it would have left > little shared code with the I2S mode anyway. > > The encoder requires that the audio be SPDIF-formatted frames only, > which alsalib will format-convert for us. > > This patch is the combined work of Eric Anholt (initial register setup > with a separate dmaengine driver and using simple-audio-card) and > Boris Brezillon (moving it all into HDMI, massive debug to get it > actually working), and which Eric has the permission to release. > > v2: Drop "-audio" from sound card name, since that's already implied > (suggestion by Boris) > > Signed-off-by: Eric Anholt Acked-by: Boris Brezillon