Path: csiph.com!1.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!news.in-chemnitz.de!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: John Keeping Newsgroups: linux.kernel Subject: [PATCH v4 14/23] drm/rockchip: dw-mipi-dsi: ensure PHY is reset Date: Fri, 24 Feb 2017 14:00:02 +0100 Message-ID: References: X-Original-To: Mark Yao Dkim-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=metanate.com; s=stronger; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=mz4BLR+SnFgDbOXVrTBye/QvUIz9lv99RmRNRJW7akg=; b=hfniAIhK8B3tpQfyd76BrS9L1PTH96Ci+L2E8r9tYf3xbUZoZRxJavbn/+/QwslVLYSmvGKOOW4hio2ToDtYy7MLJHhhaUt+LjSzY/CKtQTaF5Cw6rMTy5oncAC6EuykRJy6Sw5cOKfVmfcVM5cIQ7DovcSNtGUeUkJlKOIjPc5B8xivFmMHkb2ITOEg71w7mxlIJCE9hNIXJMCf4xNw+k83p1/kCsYIZACBYqGhFwug77x/8tR9f4aUiI3GsjNfOq6n/AhIU/dsIhd5qaXmH3NPtCYVMCZwomdVKT5sJ5qkLgIKPkuHkBb18Xcw+BPUC3BknQ4QusvVPemtU1af1g==; X-Mailer: git-send-email 2.12.0.rc0.230.gf625d4cdb9.dirty Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 35 Organization: linux.* mail to news gateway X-Original-Cc: Chris Zhong , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Sean Paul , John Keeping X-Original-Date: Fri, 24 Feb 2017 12:54:57 +0000 X-Original-Message-ID: <20170224125506.21533-15-john@metanate.com> X-Original-References: <20170224125506.21533-1-john@metanate.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1587571 Also don't power up the DSI host at this point since this is not necessary in order to configure the PHY and we do so later when selecting video or command mode. Signed-off-by: John Keeping Reviewed-by: Chris Zhong Reviewed-by: Sean Paul --- v4: - Add Sean's Reviewed-by v3: - Add Chris' Reviewed-by Unchanged in v2 --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c index 0f9be41f0361..78d676b7e516 100644 --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c @@ -397,7 +397,10 @@ static int dw_mipi_dsi_phy_init(struct dw_mipi_dsi *dsi) return testdin; } - dsi_write(dsi, DSI_PWR_UP, POWERUP); + /* Start by clearing PHY state */ + dsi_write(dsi, DSI_PHY_TST_CTRL0, PHY_UNTESTCLR); + dsi_write(dsi, DSI_PHY_TST_CTRL0, PHY_TESTCLR); + dsi_write(dsi, DSI_PHY_TST_CTRL0, PHY_UNTESTCLR); dw_mipi_dsi_phy_write(dsi, 0x10, BYPASS_VCO_RANGE | VCO_RANGE_CON_SEL(vco) | -- 2.12.0.rc0.230.gf625d4cdb9.dirty