Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From: Jens Axboe <axboe@kernel.dk>
Newsgroups: linux.kernel
Subject: Re: [PATCH] block: do not allow updates through sysfs until  registration completes
Date: Wed, 15 Feb 2017 16:50:01 +0100
Message-ID: <tba09-1Py-1@gated-at.bofh.it>
References: <taYs2-2jy-11@gated-at.bofh.it>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0
MIME-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: robomod@news.nic.it
Approved: robomod@news.nic.it
Lines: 19
Organization: linux.* mail to news gateway
Xref: csiph.com linux.kernel:1581409

On 02/14/2017 08:27 PM, Tahsin Erdogan wrote:
> When a new disk shows up, sysfs queue directory is created before elevator
> is registered. This allows a user to attempt a scheduler switch even though
> the initial registration hasn't completed yet.
> 
> In one scenario, blk_register_queue() calls elv_register_queue() and
> right before cfq_registered_queue() is called, another process executes
> elevator_switch() and replaces q->elevator with deadline scheduler. When
> cfq_registered_queue() executes it interprets e->elevator_data as struct
> cfq_data even though it is actually struct deadline_data.
> 
> Grab q->sysfs_lock in blk_register_queue() to synchronize with sysfs
> callers.

Thanks, this looks good to me - both the grabbing of the lock, and
the ordering wrt UDEV_ADD. Queued up.

-- 
Jens Axboe