Path: csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod From: Borislav Petkov Newsgroups: linux.kernel Subject: Re: [PATCH V2 2/3] x86/numa_emulation: assign physnode_mask directly from numa_nodes_parsed Date: Mon, 26 Jun 2017 20:50:01 +0200 Message-ID: References: X-Original-To: Wei Yang MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 41 Organization: linux.* mail to news gateway X-Original-Cc: kirill@shutemov.name, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, tj@kernel.org, rientjes@google.com, linux-kernel@vger.kernel.org X-Original-Date: Mon, 26 Jun 2017 20:40:26 +0200 X-Original-Message-ID: <20170626184026.eztcwsqfy3yu7fvh@pd.tnic> X-Original-References: <20170502130453.5933-1-richard.weiyang@gmail.com> <20170502130453.5933-3-richard.weiyang@gmail.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1675003 On Tue, May 02, 2017 at 09:04:52PM +0800, Wei Yang wrote: > numa_init() has already called init_func(), which is responsible for > setting numa_nodes_parsed, so use this nodemask instead of re-finding it > when calling numa_emulation(). > > This patch gets the physnode_mask directly from numa_nodes_parsed. At > the same time, it corrects the comment of these two functions. > > Signed-off-by: Wei Yang > Acked-by: David Rientjes > > --- > v2: refresh the change log based on David Rientjes comment > --- > arch/x86/mm/numa_emulation.c | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > > diff --git a/arch/x86/mm/numa_emulation.c b/arch/x86/mm/numa_emulation.c > index eb017c816de6..a6d01931b9a1 100644 > --- a/arch/x86/mm/numa_emulation.c > +++ b/arch/x86/mm/numa_emulation.c > @@ -75,13 +75,15 @@ static int __init emu_setup_memblk(struct numa_meminfo *ei, > > /* > * Sets up nr_nodes fake nodes interleaved over physical nodes ranging from addr > - * to max_addr. The return value is the number of nodes allocated. > + * to max_addr. > + * > + * Returns zero on success or negative error code. ... on error. Other than that: Reviewed-by: Borislav Petkov -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.