Path: csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod From: Theodore Ts'o Newsgroups: linux.kernel Subject: Re: [PATCH 16/32] ext4: fix ext4_xattr_cmp() Date: Thu, 22 Jun 2017 04:20:02 +0200 Message-ID: References: Dkim-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=KOoywj8oBP2ON6DvM0EMAX9kdqEDWonv/RfBnmqDYi0=; b=V1hNSoZ5VnRsyiFW62khLI4gKMPpOs4lVWkM37BDHMbiuvCgjMBeun5IL+C6Yxj3ZpT2HECy0pfY9l5BhuVQPj5H7Arl/Y+ZVasJjUOMYRh1hxOG4PRXkAFWT++cV6F8+EnjTrNIfdUzZLqvmAuCK8yA3MUHqCG8SbJGCXM+OLI=; Mail-Followup-To: Theodore Ts'o , Tahsin Erdogan , Andreas Dilger , "Darrick J . Wong" , Jan Kara , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) X-Sa-Exim-Connect-IP: X-Sa-Exim-Mail-From: tytso@thunk.org X-Sa-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 10 Organization: linux.* mail to news gateway X-Original-Cc: Andreas Dilger , "Darrick J . Wong" , Jan Kara , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org X-Original-Date: Wed, 21 Jun 2017 22:15:27 -0400 X-Original-Message-ID: <20170622021525.3c5pn5avchzhdfcq@thunk.org> X-Original-References: <20170621212142.16581-1-tahsin@google.com> <20170621212142.16581-16-tahsin@google.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1672254 On Wed, Jun 21, 2017 at 02:21:26PM -0700, Tahsin Erdogan wrote: > When a xattr entry refers to an external inode, the value data is not > available in the inline area so we should not attempt to read it using > value offset. > > Signed-off-by: Tahsin Erdogan Thanks, added to the ext4 patch queue. - Ted