Path: csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From: Shuah Khan <shuahkh@osg.samsung.com>
Newsgroups: linux.kernel
Subject: Re: [PATCH] selftests: sync: Skip the test if kernel support is not  found
Date: Fri, 02 Jun 2017 23:50:02 +0200
Message-ID: <tO2Cd-6B6-7@gated-at.bofh.it>
References: <tN9mq-3zx-9@gated-at.bofh.it>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: robomod@news.nic.it
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Approved: robomod@news.nic.it
Lines: 52
Organization: linux.* mail to news gateway
X-Original-Cc: linux-kselftest@vger.kernel.org, emilio.lopez@collabora.co.uk, gustavo.padovan@collabora.com, linux-kernel@vger.kernel.org, fathi.boudra@linaro.org, Shuah Khan <shuah@kernel.org>, Shuah Khan <shuahkh@osg.samsung.com>
X-Original-Date: Fri, 2 Jun 2017 15:43:53 -0600
X-Original-Message-ID: <970cc692-8702-dabf-a6eb-d004d9280a2f@osg.samsung.com>
X-Original-References: <1496227215-16371-1-git-send-email-mpe@ellerman.id.au>
X-Original-Sender: linux-kernel-owner@vger.kernel.org
Xref: csiph.com linux.kernel:1656583

On 05/31/2017 04:40 AM, Michael Ellerman wrote:
> The "Sync framework" test doesn't work if the kernel has no support,
> obviously. Rather than reporting a failure, check for the kernel support
> by looking for /sys/kernel/debug/sync/sw_sync, and if not found skip the
> test.
> 
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

Thanks. Applied to linux-kselftest next for 4.13-rc1

-- Shuah

> ---
>  tools/testing/selftests/sync/sync_test.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/tools/testing/selftests/sync/sync_test.c b/tools/testing/selftests/sync/sync_test.c
> index 9ea08d9f0b13..62fa666e501a 100644
> --- a/tools/testing/selftests/sync/sync_test.c
> +++ b/tools/testing/selftests/sync/sync_test.c
> @@ -29,6 +29,7 @@
>  #include <unistd.h>
>  #include <stdlib.h>
>  #include <sys/types.h>
> +#include <sys/stat.h>
>  #include <sys/wait.h>
>  
>  #include "synctest.h"
> @@ -52,10 +53,22 @@ static int run_test(int (*test)(void), char *name)
>  	exit(test());
>  }
>  
> +static int sync_api_supported(void)
> +{
> +	struct stat sbuf;
> +
> +	return 0 == stat("/sys/kernel/debug/sync/sw_sync", &sbuf);
> +}
> +
>  int main(void)
>  {
>  	int err = 0;
>  
> +	if (!sync_api_supported()) {
> +		printf("SKIP: Sync framework not supported by kernel\n");
> +		return 0;
> +	}
> +
>  	printf("[RUN]\tTesting sync framework\n");
>  
>  	err += RUN_TEST(test_alloc_timeline);
>