Path: csiph.com!goblin2!goblin3!goblin.stu.neva.ru!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From: Matthias Brugger <matthias.bgg@gmail.com>
Newsgroups: linux.kernel
Subject: Re: [PATCH v2 1/4] dt-bindings: mediatek: add bindings for MediaTek  MT7622 SoC
Date: Mon, 29 May 2017 17:20:02 +0200
Message-ID: <tMuCC-1GC-29@gated-at.bofh.it>
References: <tMsr7-8qg-5@gated-at.bofh.it> <tMsr8-8qg-19@gated-at.bofh.it> <tMuCC-1GC-23@gated-at.bofh.it>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: robomod@news.nic.it
Approved: robomod@news.nic.it
Lines: 100
Organization: linux.* mail to news gateway
Xref: csiph.com linux.kernel:1652587



On 29/05/17 17:11, Matthias Brugger wrote:
> 
> 
> On 29/05/17 14:56, sean.wang@mediatek.com wrote:
>> From: Sean Wang <sean.wang@mediatek.com>
>>
>> This adds dt-binding documentation for MediaTek MT7622 SoC
>> which currently only includes basic items such as ARM CPU,
>> MediaTek SYSIRQ and UART.
>>
>> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
>> ---
>>   
>> Documentation/devicetree/bindings/arm/mediatek.txt                    
>> | 4 ++++
>>   
>> .../devicetree/bindings/interrupt-controller/mediatek,sysirq.txt      
>> | 3 ++-
>>   
>> Documentation/devicetree/bindings/serial/mtk-uart.txt                 
>> | 1 +
>>   3 files changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/mediatek.txt 
>> b/Documentation/devicetree/bindings/arm/mediatek.txt
>> index c860b24..fc68570 100644
>> --- a/Documentation/devicetree/bindings/arm/mediatek.txt
>> +++ b/Documentation/devicetree/bindings/arm/mediatek.txt
>> @@ -12,6 +12,7 @@ compatible: Must contain one of
>>      "mediatek,mt6592"
>>      "mediatek,mt6755"
>>      "mediatek,mt6795"
>> +   "mediatek,mt7622"
>>      "mediatek,mt7623"
>>      "mediatek,mt8127"
>>      "mediatek,mt8135"
>> @@ -38,6 +39,9 @@ Supported boards:
>>   - Evaluation board for MT6795(Helio X10):
>>       Required root node properties:
>>         - compatible = "mediatek,mt6795-evb", "mediatek,mt6795";
>> +- Reference board variant 1 for MT7622:
>> +    Required root node properties:
>> +      - compatible = "mediatek,mt7622-rfb1", "mediatek,mt7622";
>>   - Evaluation board for MT7623:
>>       Required root node properties:
>>         - compatible = "mediatek,mt7623-evb", "mediatek,mt7623";
>> diff --git 
>> a/Documentation/devicetree/bindings/interrupt-controller/mediatek,sysirq.txt 
>> b/Documentation/devicetree/bindings/interrupt-controller/mediatek,sysirq.txt 
>>
>> index a89c03b..eda1183 100644
>> --- 
>> a/Documentation/devicetree/bindings/interrupt-controller/mediatek,sysirq.txt 
>>
>> +++ 
>> b/Documentation/devicetree/bindings/interrupt-controller/mediatek,sysirq.txt 
>>
>> @@ -1,4 +1,4 @@
>> -+Mediatek 65xx/67xx/81xx sysirq
>> ++Mediatek MT65xx/MT67xx/MT762x/MT81xx sysirq
>>   Mediatek SOCs sysirq support controllable irq inverter for each GIC SPI
>>   interrupt.
>> @@ -15,6 +15,7 @@ Required properties:
>>       "mediatek,mt6582-sysirq"
>>       "mediatek,mt6580-sysirq"
>>       "mediatek,mt6577-sysirq"
>> +    "mediatek,mt7622-sysirq"
>>       "mediatek,mt2701-sysirq"
> 
> This file is a mess and I posted some cleanups on the mailinglist. No 
> need for you to resubmit. If the DT maintainers are fine with my 
> cleanups, I cann change the line accordingly.
> 

I forgot:

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> Regards,
> Matthias
> 
>>   - interrupt-controller : Identifies the node as an interrupt controller
>>   - #interrupt-cells : Use the same format as specified by GIC in 
>> arm,gic.txt.
>> diff --git a/Documentation/devicetree/bindings/serial/mtk-uart.txt 
>> b/Documentation/devicetree/bindings/serial/mtk-uart.txt
>> index 0015c72..daa1eef 100644
>> --- a/Documentation/devicetree/bindings/serial/mtk-uart.txt
>> +++ b/Documentation/devicetree/bindings/serial/mtk-uart.txt
>> @@ -8,6 +8,7 @@ Required properties:
>>     * "mediatek,mt6589-uart" for MT6589 compatible UARTS
>>     * "mediatek,mt6755-uart" for MT6755 compatible UARTS
>>     * "mediatek,mt6795-uart" for MT6795 compatible UARTS
>> +  * "mediatek,mt7622-uart" for MT7622 compatible UARTS
>>     * "mediatek,mt7623-uart" for MT7623 compatible UARTS
>>     * "mediatek,mt8127-uart" for MT8127 compatible UARTS
>>     * "mediatek,mt8135-uart" for MT8135 compatible UARTS
>>