Path: csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod From: Bart Van Assche Newsgroups: linux.kernel Subject: Re: [PATCH] scsi: zero per-cmd driver data for each MQ I/O Date: Tue, 16 May 2017 02:10:01 +0200 Message-ID: References: X-Original-To: "jejb@linux.vnet.ibm.com" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "longli@microsoft.com" , "martin.petersen@oracle.com" X-Ironport-Av: E=Sophos;i="5.38,346,1491235200"; d="scan'208";a="120490330" Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=GqAD5RF0wl7N4TtZYZ4dcG7DlmoLiFPjJoUx63bUkGM=; b=f2To5X5aWJIOyBi9QM0tkh9Waenv30kJlRusFnPoei/yaaoqUPWou2Luo1qjufsuesilK01n3Uygv/9fn5EkHV82x9rqVW0PewSuWB+IgdGpH6h6d8384kavZvmkZgh3c0TeOlYvUUP7gLAfpGTP73eTt+4gp4De1zRPR9N7Ot8= Thread-Topic: [PATCH] scsi: zero per-cmd driver data for each MQ I/O Thread-Index: AdLN0Sb+ho4t8yK3r0qgJIjNbdRb6AABlBKA Accept-Language: en-US Content-Language: en-US Authentication-Results: linux.vnet.ibm.com; dkim=none (message not signed) header.d=none;linux.vnet.ibm.com; dmarc=none action=none header.from=sandisk.com; X-Originating-IP: [63.163.107.100] X-Ms-Publictraffictype: Email X-Microsoft-Exchange-Diagnostics: 1;CY1PR0401MB1533;7:DFGE1WmBcPzz90jTTaNESxS+4MUTMxO32nJHSicv9KYKfPvYyd8Z4OHh6f045tL7LmzvnNhICiFsFthr9OmHA2g7OKBdmjyqc3zI3Ajgc+mp/Oy/H1woOKBjCHF5DMLTPOaRvFV7j+wOJsowatNM2ylCfMnBQjDcH2KR1vGKE2GgA7QnxeyWGFLg1D64Y9o9KkmO7UPrOCvkrRxPQyw2CrefzhDEfTrErrUt6lzBPSGv6qW4XirRh0ouJXhpzFqXWgS4hu/H3hefobyvWaVG5ywxbLFsxMrnof9kJhURB3z5rFPJzoCzDU5llBkfqT4rBDRDSXqOq6vdIYx782Tk/A==;20:geQY0OdmHDZRbTQifl6oGsgTYfyc2tejSe3RS9L9EP9oAo2eylGjDx9V2VWbyMza1de8I1bOQxCFKFHsaqN1cncO5XzOAa1BAMAcOK4LM9BzoFYQISz+IPNTWRSU5tCLQb57d6sWi9AbgHXu+3VQSpraX05vqZBNAeavqmNR6MI= X-Ms-Office365-Filtering-Correlation-ID: f903bd02-93af-449f-29ae-08d49bee9ac0 X-Ms-Office365-Filtering-Ht: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:CY1PR0401MB1533; Wdcipoutbound: EOP-TRUE X-Microsoft-Antispam-Prvs: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-Cfa-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123558100)(20161123555025)(20161123560025)(6072148);SRVR:CY1PR0401MB1533;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0401MB1533; X-Forefront-Prvs: 03094A4065 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(39410400002)(39840400002)(39850400002)(39400400002)(39860400002)(39450400003)(51884002)(24454002)(377424004)(2501003)(6436002)(6506006)(54356999)(50986999)(6486002)(77096006)(103116003)(2900100001)(4326008)(25786009)(76176999)(33646002)(2421001)(8936002)(122556002)(102836003)(3846002)(81166006)(8676002)(36756003)(6116002)(3660700001)(3280700002)(1511001)(2906002)(66066001)(305945005)(72206003)(229853002)(2201001)(8666007)(6246003)(5660300001)(189998001)(2950100002)(7736002)(86362001)(99286003)(38730400002)(53936002)(54906002)(478600001)(6512007);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1533;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Spamdiagnosticoutput: 1:99 Spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Originatororg: sandisk.com X-Ms-Exchange-Crosstenant-Originalarrivaltime: 16 May 2017 00:00:46.5227 (UTC) X-Ms-Exchange-Crosstenant-Fromentityheader: Hosted X-Ms-Exchange-Crosstenant-ID: b61c8803-16f3-4c35-9b17-6f65f441df86 X-Ms-Exchange-Transport-Crosstenantheadersstamped: CY1PR0401MB1533 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 22 Organization: linux.* mail to news gateway X-Original-Cc: "sthemmin@microsoft.com" , "kys@microsoft.com" X-Original-Date: Tue, 16 May 2017 00:00:46 +0000 X-Original-Message-ID: <1494892845.2567.14.camel@sandisk.com> X-Original-References: X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1642135 On Mon, 2017-05-15 at 23:32 +0000, Long Li wrote: > Thanks for looking! Yes this is for chasing a bug.=20 >=20 > With the patch, we also zero the private data used by lower layer driver,= in > addition to the private data in scsi_cmnd. Hello Long, What bug did you encounter, with which combination of ULP (sd?) and LLD SCS= I driver(s) and for which request type (REQ_OP_*)? You will have to mention t= hat information in the patch description anyway if you want your patch to get accepted. If the bug that you encountered only occurs with a single LLD, would it be possible to implement a fix by modifying the LLD instead of the SCSI core? Thanks, Bart.=