Path: csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Newsgroups: linux.kernel
Subject: Re: [PATCH] kernfs: handle null pointers while printing node name and  path
Date: Wed, 08 Feb 2017 14:30:02 +0100
Message-ID: <t8AtQ-Rq-9@gated-at.bofh.it>
References: <t8yBH-88n-5@gated-at.bofh.it> <t8A0O-rN-29@gated-at.bofh.it> <t8Aat-Kl-1@gated-at.bofh.it> <t8AtQ-Rq-11@gated-at.bofh.it>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1
MIME-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: robomod@news.nic.it
Approved: robomod@news.nic.it
Lines: 29
Organization: linux.* mail to news gateway
Xref: csiph.com linux.kernel:1576573



On 08.02.2017 16:23, Greg Kroah-Hartman wrote:
> On Wed, Feb 08, 2017 at 03:59:06PM +0300, Konstantin Khlebnikov wrote:
>>
>>
>> On 08.02.2017 15:51, Greg Kroah-Hartman wrote:
>>> On Wed, Feb 08, 2017 at 02:28:55PM +0300, Konstantin Khlebnikov wrote:
>>>> Null kernfs nodes could be found at cgroups during construction.
>>>
>>> Really?  Does this happen today?  Is this an issue for older kernels as
>>> well?
>>
>> This happended again recently: https://lkml.org/lkml/2017/1/26/126
>> LTP easily crashes everything since 4.6
>
> Why did you drop the "Fixes:" and cc: stable line from the patch you
> sent me?  That would have saved me asking you this :(

No, this _was_ proposed as a fix but now bug fixed differently right in cgroups.
Now this patch just a cleanup / safer api.

>
> Care to fix this up and send a new version with that info in it?
>
> thanks,
>
> greg k-h
>