Path: csiph.com!feeder.erje.net!2.eu.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod From: Andy Shevchenko Newsgroups: linux.kernel Subject: Re: [PATCH 0/3] Get rid of BUG() Date: Sat, 28 Jan 2017 14:40:01 +0100 Message-ID: References: X-Original-To: Jarkko Sakkinen Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=qtQz6VFYY5kXWzfXao50wfyrYHly8a4XHNZ3ywml0CY=; b=gHOT8I/gvqy+ZiEFCsmXEnAcC2os/tRuKD4t4i1ryh+S5CKT7ACrc8XxQEEu5Zc/tI H5GKTvCwTPLqGLkjUOiDiCP6Sxv40ey2Oz0vesi/y7bNrer3ZvWWTNqob2IlDDlaKmTP dJEXSpYsABL3hMeVTKjqXe6Zj5eYkOtN7MjU7y6mrbtPiqbVXjF+FQqNbsSXeZAFMeeI H9f3OORoiimgAP+AJO5M6VhYLkwQSHsYZo463LKm2JEGpHTB75EojXjkHajfqy4lAF1w jWNtfVil3DE3XAGwCfpHOHG/sODoObgEigoD76vM71GQ1pkqy6xbR+W82syZBpWCLe8c yK6g== X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=qtQz6VFYY5kXWzfXao50wfyrYHly8a4XHNZ3ywml0CY=; b=RksGjFMW6aa4RmI7bZZJbecCGpmHDamHL+lyCmMzxjDNUlI0bO+MM0PymICv8XrPaE I0c1s7wPKEWfP8QvruTGpN4QuAigA1YW6F7mM4EcGX5j9kiThWQEfvVOP0+CfZ+q68oE y8ABXUHXCKcIhPQkCtD/BarLDsxDry/9QU2llJmO76U1smIxVqvSyRKPCDUXpLjZygf8 GYzGFJ6qOQ3YVByeSZQV7HnKxjvtwVZsCSouNQVFLbjfCu2inJJ6N4mdQdsaD8cDFdcF O2t2Ty10WbX8MzWC8aXz1QBNhKkndysdUFE3FyRBh8w6EWX5dN5+8tBK/u1aWpyPTz71 71CQ== X-Gm-Message-State: AIkVDXJbPTIpPBXdScY5K+ErJayyZcF0vY/N7/vxx8i8ywXz7VOvxrhEQe99AGmHZOvKiuP2EnQ33+bfVqB6YQ== X-Received: by 10.200.38.102 with SMTP id v35mr13168508qtv.246.1485610338049; Sat, 28 Jan 2017 05:32:18 -0800 (PST) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 34 Organization: linux.* mail to news gateway X-Original-Cc: intel-sgx-kernel-dev@lists.01.org, open list , "open list:X86 PLATFORM DRIVERS" X-Original-Date: Sat, 28 Jan 2017 15:32:17 +0200 X-Original-Message-ID: X-Original-References: <20170126212038.12809-1-jarkko.sakkinen@linux.intel.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1568902 On Thu, Jan 26, 2017 at 11:20 PM, Jarkko Sakkinen wrote: > The use of BUG() is not favored for any new kernel code. This patch set > implements more reasonable error recovery. In all cases the recovery is not > ideal but it is an improvement to the current situation. > > In addition, sgx_free_page() has been simplified by removing the parameter for > skipping EREMOVE. EREMOVE can be successfully executed for an unused EPC page. > > Jarkko Sakkinen (3): By some reason I only see first patch. What's going on? > intel_sgx: do not use BUG() in sgx_free_page() > intel_sgx: remove flags parameter from sgx_free_page() > intel_sgx: fix error paths for EBLOCK and ETRACK > > drivers/platform/x86/intel_sgx.h | 4 +- > drivers/platform/x86/intel_sgx_ioctl.c | 12 ++-- > drivers/platform/x86/intel_sgx_page_cache.c | 89 +++++++++++++++-------------- > drivers/platform/x86/intel_sgx_util.c | 6 +- > drivers/platform/x86/intel_sgx_vma.c | 6 +- > 5 files changed, 55 insertions(+), 62 deletions(-) > > -- > 2.9.3 > -- With Best Regards, Andy Shevchenko