Path: csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: Rob Herring Newsgroups: linux.kernel Subject: Re: [PATCH v1 1/2] Documentation: mtk-quadspi: update DT bindings Date: Wed, 18 Jan 2017 23:10:03 +0100 Message-ID: References: X-Original-To: Boris Brezillon X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=uNdDGpiPA8kxCCmwmbx65VNgiV0QYVovWN8YL9AJttQ=; b=Ez+bqJqOc7cDwVQnkrpgA3a27iKQZc03LqFTSVKnf/jB6lLKTX3MSvkDc8cv5Jokiw UnGodZHpjIIOatOjNcBdWUcVuoUtSJVB9i31ApKscOIjCmyPy2aWB8AZv6/MHeSAC8u/ XsRgxQh5VmG03VCcgyrkd2rR8vgPEoyASWjeuSbpWDOQCqgfPru0Q/lLa61ZJfaiLoKC 2U/2sxcLyeYOzDMts9Ms0wVwz3NUKfSWMUmgfZ80gX4eO+TwUXKQwPJCG6IY+mdFmrSJ QaceIURehMW0hhG9JFI/9fiqSsvUOfAEvNV9r7/XmEu7Ygl9UwjT/B1bddOApj3YJDyQ 3+sA== X-Gm-Message-State: AIkVDXKxlDNcZY9Zm1if5d5un+a9XsJja8/+aY6ANCjUjTyulRL9/hV8u1Vvq5/jCfd6vQ== X-Received: by 10.157.29.143 with SMTP id y15mr3067007otd.214.1484777290917; Wed, 18 Jan 2017 14:08:10 -0800 (PST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 30 Organization: linux.* mail to news gateway X-Original-Cc: Guochun Mao , David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , Cyrille Pitchen , Mark Rutland , Matthias Brugger , Russell King , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org X-Original-Date: Wed, 18 Jan 2017 16:08:09 -0600 X-Original-Message-ID: <20170118220809.pmaa2f3kwiddehti@rob-hp-laptop> X-Original-References: <1484291609-20195-1-git-send-email-guochun.mao@mediatek.com> <1484291609-20195-2-git-send-email-guochun.mao@mediatek.com> <20170113151326.11e9451a@bbrezillon> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1562222 On Fri, Jan 13, 2017 at 03:13:26PM +0100, Boris Brezillon wrote: > On Fri, 13 Jan 2017 15:13:28 +0800 > Guochun Mao wrote: > > > Add "mediatek,mt2701-nor" for nor flash node's compatible. > > > > Signed-off-by: Guochun Mao > > --- > > .../devicetree/bindings/mtd/mtk-quadspi.txt | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt > > index fb314f0..f83d31d 100644 > > --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt > > +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt > > @@ -1,7 +1,9 @@ > > * Serial NOR flash controller for MTK MT81xx (and similar) > > > > Required properties: > > -- compatible: should be "mediatek,mt8173-nor"; > > +- compatible: should contain: > > + "mediatek,mt2701-nor" for MT2701, > > + "mediatek,mt8173-nor" for MT8173. > > Do you need to define a new compatible? If the IPs are exactly the same > in both SoCs it shouldn't be needed. Rather the 2701 should contain both strings in that case. Rob