Path: csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.unit0.net!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups: linux.kernel
Subject: Re: [PATCH/RFT 11/12] ARM: dts: da850: Add the usb ohci device node
Date: Fri, 07 Oct 2016 19:20:01 +0200
Message-ID: <spGYp-3AS-15@gated-at.bofh.it>
References: <spGvn-3aK-7@gated-at.bofh.it> <spGvp-3aK-73@gated-at.bofh.it>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=qeHqLfFTWK+qXBTO4rFdFPbxXDjMgx/jUYqnT5pYflA=; b=LbXHtLuNLhhoVoRQm6qpSzbAcG6OaqUoVNon0JalbnKsLVyOtQsMTzZyyKTWPRu3hL UItLR81rvInrAV/Mt5K+wFu/4n/sgA5REbBUrbRxYow3abW/qjdOjaL3IqbfjOtz9Ebx DPWKBRNbh65oRx3OKoHLGnBKiQlVb1/2SNDPBbpIBLrZ5UPmmWDsp5JoTPLCYi+CHkfD yqVogagBUc36ZrueCyhpKd8zb0c/t0yB0Ntn8RFUCVypExrS6/aq5eUQzuhSq3isfLhv T595zT6JXozQGBjU+ryrj8U2tkwHLOeJ+Vt5b/g/7E/Gq9eF2/0ob8zmoV5q+VpLwgov dZrg==
X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding; bh=qeHqLfFTWK+qXBTO4rFdFPbxXDjMgx/jUYqnT5pYflA=; b=aENgsmX+Nz4mHNSC8YqZyA8roDToWfKINRC0uOJnbKhcsz68zO5Qk6LhAdszY3c2no QjsnbQ3GW3GHeCqLP3kt83Zp6vHGMRjlbFd9huyGyjMnwDZ0wxkiKlno4uqIc0w3Y3hW WJSdQI8HJ3ihAvD2GcXXtcfsCJhzfs4FV1spOwxT6ow6i0OZ6FKIXQ073RRhmyWZtvSw b9Mm8O1ydDzLCfiHDgQq4cQzBnfxcbDtKgSXXbtiCZZM7Mjgt6VbssOtWn3d2rnissA7 h/WBr1F6DTN2RIZcjXgFY/3inu7P2vsuRnLyLvX5sNeNXpmW5pytfRFfi9ZilcHd129W MEyg==
X-Gm-Message-State: AA6/9RlFKCyEzm2hFflSaHK+Bgc/JDAnt6MfOjhE0H9rViHpi0CG94RTOlcnclueUSP3wg==
X-Received: by 10.25.43.208 with SMTP id r199mr9428532lfr.140.1475860307279; Fri, 07 Oct 2016 10:11:47 -0700 (PDT)
Organization: Cogent Embedded
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: robomod@news.nic.it
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Approved: robomod@news.nic.it
Lines: 30
X-Original-Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
X-Original-Date: Fri, 7 Oct 2016 20:11:44 +0300
X-Original-Message-ID: <7227c5ff-4f9e-bcb5-ea0f-cdd122d42445@cogentembedded.com>
X-Original-References: <1475858577-10366-1-git-send-email-ahaslam@baylibre.com> <1475858577-10366-12-git-send-email-ahaslam@baylibre.com>
X-Original-Sender: linux-kernel-owner@vger.kernel.org
Xref: csiph.com linux.kernel:1497370

Hello.

On 10/07/2016 07:42 PM, ahaslam@baylibre.com wrote:

> From: Axel Haslam <ahaslam@baylibre.com>
>
> This adds the device tree node for the usb11 (ohci)
> controller present in the da850 family of SoC's.
>
> Signed-off-by: Axel Haslam <ahaslam@baylibre.com>
> ---
>  arch/arm/boot/dts/da850.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
> index 33fcdce..afae565 100644
> --- a/arch/arm/boot/dts/da850.dtsi
> +++ b/arch/arm/boot/dts/da850.dtsi
> @@ -381,6 +381,14 @@
>  			#phy-cells = <1>;
>  			status = "disabled";
>  		};
> +		usb11: usb11@0225000 {

    No, usb@<unit-address> to comply with the DT spec the node names should be 
generic.

[...]

MBR, Sergei