Path: csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod From: Jaehoon Chung Newsgroups: linux.kernel Subject: Re: [PATCH] mmc: dw_mmc: minor cleanup for dw_mci_adjust_fifoth Date: Thu, 22 Sep 2016 06:30:02 +0200 Message-ID: References: X-Auditid: cbfee68e-f79fa6d0000063e2-15-57e35db25362 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnkeLIzCtJLcpLzFFi42JZI2JSqLsp9nG4wbUFShaXd81hszjyv5/R 4tOD/8wWd56sZ7U4vjbcgdXjzrU9bB6bl9R7/J21n8Xj8ya5AJYoLpuU1JzMstQifbsErozz vc0sBa3sFYd+9DA3MG5j7WLk5JAQMJFY/ekjM4QtJnHh3nq2LkYuDiGBFYwSf6fNZ4cpal60 jgkisZRRYsvV52DdQgIPGCUWfJUAsYUFPCS+ndnACGKLCPhJbN2xFWrSPEaJ+33bmUASzAKJ Eu+PXQCz2QR0JLZ/Ow5kc3DwCthJ/F/PD2KyCKhK3J6XCFIhKhAmcfLcObAbeAUEJX5MvscC YnMKeErMvfyMFaScWUBP4v5FLYjh8hKb17xlBtkqIbCLXeLv8glgj7EICEh8m3yIBaReQkBW YtMBqH8lJQ6uuMEygVFsFpINsxCmzkIydQEj8ypG0dSC5ILipPQiI73ixNzi0rx0veT83E2M wHg6/e9Z3w7GmwesDzEKcDAq8fD+EH8cLsSaWFZcmXuI0RToiInMUqLJ+cCozSuJNzQ2M7Iw NTE1NjK3NFMS502Q+hksJJCeWJKanZpakFoUX1Sak1p8iJGJg1OqgXHNj3xVu3Xz59z7fXuf 0u/V6mZbzQ/Je/l+SrPsehNwavmO7IUnnNiUM3+lHZXP2COeeWdKLOPKY9wPq6wkxarZuivX pekvtPzx+pni9zkv5Bb0qKQV7qs0Zl9ZMVXrlYDT5O5z/9JfP7VcLPUlPCb++yYZ5wvrLFUO pfvoRG94+nLhnthLpZxKLMUZiYZazEXFiQBAn+kXogIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrDIsWRmVeSWpSXmKPExsVy+t9jAd1NsY/DDa7ek7W4vGsOm8WR//2M Fp8e/Ge2uPNkPavF8bXhDqwed67tYfPYvKTe4++s/SwenzfJBbBENTDaZKQmpqQWKaTmJeen ZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gCtVVIoS8wpBQoFJBYXK+nbYZoQ GuKmawHTGKHrGxIE12NkgAYS1jBmnO9tZiloZa849KOHuYFxG2sXIyeHhICJRPOidUwQtpjE hXvr2boYuTiEBJYySmy5+hysSEjgAaPEgq8SILawgIfEtzMbGEFsEQE/ia07tkI1zGOUuN+3 HWwSs0CixPtjF8BsNgEdie3fjgPZHBy8AnYS/9fzg5gsAqoSt+clglSICoRJnDx3jh3E5hUQ lPgx+R4LiM0p4Ckx9/IzVpByZgE9ifsXtSCGy0tsXvOWeQKjwCwkHbMQqmYhqVrAyLyKUSK1 ILmgOCk91zAvtVyvODG3uDQvXS85P3cTIzhmn0ntYDy4y/0QowAHoxIPr8b3R+FCrIllxZW5 hxglOJiVRHgnRz8OF+JNSaysSi3Kjy8qzUktPsRoCvTFRGYp0eR8YDrJK4k3NDYxM7I0Mje0 MDI2VxLnffx/XZiQQHpiSWp2ampBahFMHxMHp1QD49oquRPmwR/dvhv1LdqlIGRR8eSRjfRz BulYwTUXt1xSuHjvjskcvXBnyd/N709seug66eIE8b/6b72LZysI1uiyztn4pbjxQNqxgw1N UczW7xi53qzS2CG5n0XfgYHxiBGnpHVMmWXNqR7OmI5rE/sntnvVxLd5LPh5YSfDzgUrSibs uXgpRomlOCPRUIu5qDgRAClKd1PvAgAA Dlp-Filter: Pass X-Mtr: 20000000000000000@CPGS X-Cfilter-Loop: Reflected Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 34 Organization: linux.* mail to news gateway X-Original-Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org X-Original-Date: Thu, 22 Sep 2016 13:27:30 +0900 X-Original-Message-ID: X-Original-References: <1474425625-24178-1-git-send-email-shawn.lin@rock-chips.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1488528 On 09/21/2016 11:40 AM, Shawn Lin wrote: > msize and rx_wmark are properly initialized, we dont't > need to assign them again. Applied on my tree. Thanks! Best Regards, Jaehoon Chung > > Signed-off-by: Shawn Lin > --- > > drivers/mmc/host/dw_mmc.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 22dacae..d838428 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -876,11 +876,8 @@ static void dw_mci_adjust_fifoth(struct dw_mci *host, struct mmc_data *data) > * MSIZE is '1', > * if blksz is not a multiple of the FIFO width > */ > - if (blksz % fifo_width) { > - msize = 0; > - rx_wmark = 1; > + if (blksz % fifo_width) > goto done; > - } > > do { > if (!((blksz_depth % mszs[idx]) || >