Path: csiph.com!goblin3!goblin.stu.neva.ru!news.redatomik.org!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod From: John Garry Newsgroups: linux.kernel Subject: [PATCH 05/15] hisi_sas: use safe BITS_PER_BYTE for slot tag size calculation Date: Tue, 06 Sep 2016 17:30:03 +0200 Message-ID: References: X-Original-To: , X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.212.75] X-Cfilter-Loop: Reflected X-Mirapoint-Virus-Rapid-Raw: score=unknown(0), refid=str=0001.0A020204.57CEDF85.002D,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-ID: a94117ef041605fae05e97f303a72525 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 23 Organization: linux.* mail to news gateway X-Original-Cc: , , , , , , John Garry X-Original-Date: Tue, 6 Sep 2016 23:36:15 +0800 X-Original-Message-ID: <1473176185-217808-6-git-send-email-john.garry@huawei.com> X-Original-References: <1473176185-217808-1-git-send-email-john.garry@huawei.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1477539 The memory calculation for the tags bitmap should use BITS_PER_BYTE macro instead of coincidental same value of sizeof(unsigned long). Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c index 0e48751..dcb17a3 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_main.c +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c @@ -1309,7 +1309,7 @@ static int hisi_sas_alloc(struct hisi_hba *hisi_hba, struct Scsi_Host *shost) memset(hisi_hba->breakpoint, 0, s); hisi_hba->slot_index_count = max_command_entries; - s = hisi_hba->slot_index_count / sizeof(unsigned long); + s = hisi_hba->slot_index_count / BITS_PER_BYTE; hisi_hba->slot_index_tags = devm_kzalloc(dev, s, GFP_KERNEL); if (!hisi_hba->slot_index_tags) goto err_out; -- 1.9.1