Path: csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From: Mathieu Poirier <mathieu.poirier@linaro.org>
Newsgroups: linux.kernel
Subject: Re: [PATCH] drivers/hwtracing: add missing header dependencies
Date: Tue, 06 Sep 2016 17:30:02 +0200
Message-ID: <seqtY-3JB-39@gated-at.bofh.it>
References: <sejsu-7qJ-33@gated-at.bofh.it>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Sender: robomod@news.nic.it
Approved: robomod@news.nic.it
Lines: 33
Organization: linux.* mail to news gateway
Xref: csiph.com linux.kernel:1477516

On 6 September 2016 at 01:56, Baoyou Xie <baoyou.xie@linaro.org> wrote:
> We get 1 warning when building kernel with W=1:
> drivers/hwtracing/coresight/coresight-etm-perf.c:345:5: warning: no previous prototype for 'etm_perf_symlink' [-Wmissing-prototypes]
>
> In fact, this function is declared in coresight-etm-perf.h, so this patch
> add missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
>  drivers/hwtracing/coresight/coresight-etm-perf.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
> index 755125f..d936e82 100644
> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> @@ -28,6 +28,7 @@
>  #include <linux/workqueue.h>
>
>  #include "coresight-priv.h"
> +#include "coresight-etm-perf.h"

I already fixed this one in my next branch -  it will show up in the 4.9 cycle.

Thanks for the submission,
Mathieu

>
>  static struct pmu etm_pmu;
>  static bool etm_perf_up;
> --
> 2.7.4
>