Path: csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: Daniel Wagner Newsgroups: linux.kernel Subject: Re: [PATCH v4 2/3] tracing: Add trace_irqsoff tracepoints Date: Tue, 30 Aug 2016 13:40:01 +0200 Message-ID: References: X-Ctch-Refid: str=0001.0A0C0202.57C56E54.01D3,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.10.50.53] X-Clientproxiedby: CIT-HM8-EX01.bmw-carit.intra (10.40.100.13) To CIT-HM8-EX01.bmw-carit.intra (10.40.100.13) Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 25 Organization: linux.* mail to news gateway X-Original-Cc: Ingo Molnar , Arnd Bergmann , , Masami X-Original-Date: Tue, 30 Aug 2016 13:30:26 +0200 X-Original-Message-ID: X-Original-References: <1472552924-22297-1-git-send-email-binoy.jayan@linaro.org> <1472552924-22297-3-git-send-email-binoy.jayan@linaro.org> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1472425 Hi Binoy, On 08/30/2016 12:28 PM, Binoy Jayan wrote: > +static inline void trace_latency_preempt_mark_ts(enum latency_type ltype) > +{ > + this_cpu_write(lat_ts[ltype], (cycle_t) trace_clock_local()); > +} > + > +static inline void latency_trace(enum latency_type type) > +{ > + trace_latency_preempt(type, > + (cycle_t) trace_clock_local() - this_cpu_read(lat_ts[type])); > +} As Masami has pointed out, the prefix trace_ should not be used. Also having trace_latency_ and latency_trace_ is kind of confusing. What about {start|stop}_latency_timing()? It would match the existing {start|stop}_critical_timing(). Or is it too close and it leads to confusion? Another idea is {start|stop}_latency_preempt(). This matches the trace_latency_preempt_enable() function. cheers, daniel