Path: csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.roellig-ltd.de!open-news-network.org!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: Arnaldo Carvalho de Melo Newsgroups: linux.kernel Subject: Re: [PATCH 1/4] perf, tools: Add probing for xed Date: Tue, 03 Jan 2017 19:50:01 +0100 Message-ID: References: X-Original-To: Andi Kleen MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-URL: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 15 Organization: linux.* mail to news gateway X-Original-Cc: Jiri Olsa , Andi Kleen , jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org X-Original-Date: Tue, 3 Jan 2017 15:39:46 -0300 X-Original-Message-ID: <20170103183946.GK27864@kernel.org> X-Original-References: <20170103090029.17621-1-andi@firstfloor.org> <20170103090029.17621-2-andi@firstfloor.org> <20170103145854.GB26251@krava> <20170103151106.GX8388@tassilo.jf.intel.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1550088 Em Tue, Jan 03, 2017 at 07:11:06AM -0800, Andi Kleen escreveu: > > please don't put it in FEATURE_DISPLAY.. AFAICS there's not any xed > > package yet, just the sources, so the "xed: OFF" build message would > > bother almost everyone probably for long time.. > > It should be eventually packaged. How would people know they are missing > it without displaying it? I think it has to, otherwise most people will > miss out on the feature. Silent failure is bad. Right, you have a point, we should have some warning to the user for when features are not being automatically probed for, i.e. extra features may be enabled using special command line settings, read the docs to see how. - Arnaldo