Path: csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod From: Peter Chen Newsgroups: linux.kernel Subject: Re: [PATCH v10 0/8] power: add power sequence library Date: Tue, 20 Dec 2016 05:40:01 +0100 Message-ID: References: X-Original-To: Krzysztof Kozlowski Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=uUc3hEbPfX4zXjPOMohTyDs3Q5aMyd4XnNMZNCuHcto=; b=ewn/XQGdnBsRQ1JAeceLI1fqL2iqwaj9lBvy3dsFmfezenWzJwELcVY2pXMCjReszG UiOi6rFhQqDoncc1DRefZq/Q0y8f+JdvzSKSxnKTB28AtOWrwTxrbgVReqr3nuT+DG6k GbKgdxi/IaX7Yiiw8xDTkoKCpg4QHdcdwpP5u8f7QuJQgwbqW91Ik44T8d9KugpqF7W+ LCvNIcmLKVrU60Cb+ii4qeak3C/QlRHQfIMvvwxHMZnLUqQpCMPHLlsv+fjB6eWVhjy3 lqeas5jobMbIiKfdNPNfkVrkwU5Pk3MHgG20sp/IG27rMOEBRqUafIdVW7vSnC5jI/lJ ku2g== X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=uUc3hEbPfX4zXjPOMohTyDs3Q5aMyd4XnNMZNCuHcto=; b=R9iF72YgNHnNoOBGnd2vSjxvLNyoCCCBuykwh82OEVfQHYu6WxsHuIAnScL00pZGoK 1tA2oncHchyHz57uIKGKdXdNzeaf3NEFgJmgceQ0P3JCAqSWTFTwt+TgX5LnLVDt/brt 4xxT5vhaOr7jOGsfMIMNHqHmGVMWX8CFUNoTo32smsM44z4PdHTJissWlmgOi7cor4el FfF01c92Va8eldKyUL4C1JtC+ODO0hDwnVbYgVn+ZPHg18EKOdya3+QiG8IH0ZvfSK6o rrAT3LT6HIdzwltmYITLrHBRjGicyvyi53/ldOE3pF8clbEiT3PYWkvc4Zb1akSnac8E BA8w== X-Gm-Message-State: AKaTC02TD9gtlwiz+36PA9A/fN8VghjBZf7ezoy1jSEHQknhp/LmLbs1lTIo1G4yYzXJig== X-Received: by 10.84.134.131 with SMTP id 3mr39496553plh.89.1482208248112; Mon, 19 Dec 2016 20:30:48 -0800 (PST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 55 Organization: linux.* mail to news gateway X-Original-Cc: Peter Chen , mark.rutland@arm.com, ulf.hansson@linaro.org, heiko@sntech.de, stephen.boyd@linaro.org, linux-kernel@vger.kernel.org, gary.bisson@boundarydevices.com, festevam@gmail.com, stillcompiling@gmail.com, arnd@arndb.de, dbaryshkov@gmail.com, vaibhav.hiremath@linaro.org, mka@chromium.org, stern@rowland.harvard.edu, devicetree@vger.kernel.org, mail@maciej.szmigiero.name, pawel.moll@arm.com, linux-pm@vger.kernel.org, s.hauer@pengutronix.de, troy.kisky@boundarydevices.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, oscar@naiandei.net, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, rjw@rjwysocki.net, sre@kernel.org, broonie@kernel.org, p.zabel@pengutronix.de, shawnguo@kernel.org X-Original-Date: Tue, 20 Dec 2016 12:31:12 +0800 X-Original-Message-ID: <20161220043112.GA10071@b29397-desktop> X-Original-References: <1479087359-7547-1-git-send-email-peter.chen@nxp.com> <20161219191504.GA18988@kozik-lap> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1544896 On Mon, Dec 19, 2016 at 09:15:04PM +0200, Krzysztof Kozlowski wrote: > On Mon, Nov 14, 2016 at 09:35:51AM +0800, Peter Chen wrote: > > Hi all, > > > > This is a follow-up for my last power sequence framework patch set [1]. > > According to Rob Herring and Ulf Hansson's comments[2]. The kinds of > > power sequence instances will be added at postcore_initcall, the match > > criteria is compatible string first, if the compatible string is not > > matched between dts and library, it will try to use generic power sequence. > > > > The host driver just needs to call of_pwrseq_on/of_pwrseq_off > > if only one power sequence instance is needed, for more power sequences > > are used, using of_pwrseq_on_list/of_pwrseq_off_list instead (eg, USB hub driver). > > > > In future, if there are special power sequence requirements, the special > > power sequence library can be created. > > > > This patch set is tested on i.mx6 sabresx evk using a dts change, I use > > two hot-plug devices to simulate this use case, the related binding > > change is updated at patch [1/6], The udoo board changes were tested > > using my last power sequence patch set.[3] > > > > Except for hard-wired MMC and USB devices, I find the USB ULPI PHY also > > need to power on itself before it can be found by ULPI bus. > > > > [1] http://www.spinics.net/lists/linux-usb/msg142755.html > > [2] http://www.spinics.net/lists/linux-usb/msg143106.html > > [3] http://www.spinics.net/lists/linux-usb/msg142815.html > > > > Changes for v10: > > - Improve the kernel-doc for power sequence core, including exported APIs and > > main structure. [Patch 2/8] > > - Change Kconfig, and let the user choose power sequence. [Patch 2/8] > > - Delete EXPORT_SYMBOL and change related APIs as local, these APIs do not > > be intended to export currently. [Patch 2/8] > > - Selete POWER_SEQUENCE at USB core's Kconfig. [Patch 4/8] > > Hi Peter, > > It is great that you continued the work on this. > > I saw (in some previous mails) your repo mentioned: > https://git.kernel.org/cgit/linux/kernel/git/peter.chen/usb.git/ > Does it contain the recent version of this patchset? > > I want to build on top of it fixes for usb3503 on Odroid U3 board. Krzysztof, I put v10 patch set at branch: pwrseq-lib. It seems there are no more comments I will send my v11 patch set after new year holiday. -- Best Regards, Peter Chen